From: "H. Peter Anvin" <hpa@zytor.com>
To: David Miller <davem@davemloft.net>
Cc: akpm@linux-foundation.org, samuel.thibault@ens-lyon.org,
linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de,
andi@firstfloor.org, netdev@vger.kernel.org
Subject: Re: [PATCH,TRIVIAL] Fix csum_ipv6_magic asm memory clobber
Date: Wed, 30 Sep 2009 16:45:33 -0700 [thread overview]
Message-ID: <4AC3ED9D.6030701@zytor.com> (raw)
In-Reply-To: <20090930.162233.208543104.davem@davemloft.net>
On 09/30/2009 04:22 PM, David Miller wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Wed, 30 Sep 2009 16:19:39 -0700
>
>> From: Samuel Thibault <samuel.thibault@ens-lyon.org>
>>
>> Just like ip_fast_csum, the assembly snippet in csum_ipv6_magic needs a
>> memory clobber, as it is only passed the address of the buffer, not a
>> memory reference to the buffer itself.
>>
>> This caused failures in Hurd's pfinetv4 when we tried to compile it with
>> gcc-4.3 (bogus checksums).
>>
>> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
> I'm happy to see this go in via the x86 tree, and thus:
>
> Acked-by: David S. Miller <davem@davemloft.net>
I'll put it in x86/urgent tonight or early tomorrow morning (just about
to leave for the airport.)
-hpa
prev parent reply other threads:[~2009-09-30 23:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 19:27 [PATCH,TRIVIAL] Fix csum_ipv6_magic asm memory clobber Samuel Thibault
2009-09-30 22:40 ` Andrew Morton
2009-09-30 22:45 ` H. Peter Anvin
2009-09-30 23:01 ` Samuel Thibault
2009-09-30 23:19 ` Andrew Morton
2009-09-30 23:22 ` David Miller
2009-09-30 23:45 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC3ED9D.6030701@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox