public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@snapgear.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Ungerer <gerg@uclinux.org>,
	Len Sorensen <lsorense@csclub.uwaterloo.ca>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 11/34] move mcf_remove to .devexit.text
Date: Fri, 02 Oct 2009 10:53:35 +1000	[thread overview]
Message-ID: <4AC54F0F.7040202@snapgear.com> (raw)
In-Reply-To: <1254385718-14254-11-git-send-email-u.kleine-koenig@pengutronix.de>

Hi Uwe,

Uwe Kleine-König wrote:
> The function mcf_remove is used only wrapped by __devexit_p so define it
> using __devexit.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Greg Ungerer <gerg@uclinux.org>
> Cc: Len Sorensen <lsorense@csclub.uwaterloo.ca>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: Alan Cox <alan@linux.intel.com>
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/serial/mcf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/serial/mcf.c b/drivers/serial/mcf.c
> index b443824..7bb5fee 100644
> --- a/drivers/serial/mcf.c
> +++ b/drivers/serial/mcf.c
> @@ -602,7 +602,7 @@ static int __devinit mcf_probe(struct platform_device *pdev)
>  
>  /****************************************************************************/
>  
> -static int mcf_remove(struct platform_device *pdev)
> +static int __devexit mcf_remove(struct platform_device *pdev)
>  {
>  	struct uart_port *port;
>  	int i;

Looks good. I'll add that to the m68knommu git, for-linus branch.

Thanks
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com

  reply	other threads:[~2009-10-02  0:54 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-01  8:26 [PATCH 00/35] fix usage of __{,dev}exit_p Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 01/34] move asic3_remove to .devexit.text Uwe Kleine-König
2009-10-01 17:30   ` Samuel Ortiz
2009-10-01  8:28 ` [PATCH 02/34] move atp870u_remove " Uwe Kleine-König
2009-10-01 14:20   ` James Bottomley
2009-10-02 19:13     ` Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 03/34] move bbc_remove " Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 04/34] don't use __devexit_p to wrap excite_nand_remove Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 05/34] move grover_remove to .devexit.text Uwe Kleine-König
2009-10-06  5:05   ` Dmitry Torokhov
2009-10-01  8:28 ` [PATCH 06/34] don't use __devexit_p to wrap hal2_remove Uwe Kleine-König
2009-10-01  8:36   ` Takashi Iwai
2009-10-01  8:53     ` Uwe Kleine-König
2009-10-02  9:02       ` Takashi Iwai
2009-10-02  9:20         ` Uwe Kleine-König
2009-10-02  9:42           ` Takashi Iwai
2009-10-01  8:28 ` [PATCH 07/34] move ilo_remove to .devexit.text Uwe Kleine-König
2009-10-01 14:10   ` Altobelli, David
2009-10-01 17:44     ` Uwe Kleine-König
2009-10-01 17:49       ` Altobelli, David
2009-10-01  8:28 ` [PATCH 08/34] move initio_remove_one " Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 09/34] don't use __devexit_p to wrap iodev_remove Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 10/34] don't use __devexit_p to wrap lasi700_driver_remove Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 11/34] move mcf_remove to .devexit.text Uwe Kleine-König
2009-10-02  0:53   ` Greg Ungerer [this message]
2009-10-01  8:28 ` [PATCH 12/34] move megaraid_detach_one " Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 13/34] don't use __devexit_p to wrap meth_remove Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 14/34] don't wrap mlx4_remove_one in __devexit_p Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 15/34] move mpc85xx_pci_err_remove to .devexit.text Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 16/34] move mv64x60_pci_err_remove " Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 17/34] move mxcnd_remove to .exit.text Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 18/34] don't use __devexit_p to wrap NCR_Q720_remove Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 19/34] move s3c_adc_remove to .devexit.text Uwe Kleine-König
2009-10-02  7:20   ` Ben Dooks
2009-10-01  8:28 ` [PATCH 20/34] move s3c_pwm_remove " Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 21/34] wrap sc26xx_driver_remove by __exit_p Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 22/34] don't use __devexit_p to wrap sgiseeq_remove Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 23/34] don't use __devexit_p to wrap sgiwd93_remove Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 24/34] don't use __devexit_p to wrap snd_sgio2audio_remove Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 25/34] don't use __devexit_p to wrap snirm710_driver_remove Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 26/34] move spidev_remove to .devexit.text Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 27/34] move stex_remove " Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 28/34] move vhci_hcd_remove " Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 29/34] move virtballoon_remove " Uwe Kleine-König
2009-10-01  9:35   ` Michael S. Tsirkin
2009-10-01  9:52     ` Uwe Kleine-König
2009-10-01 10:07       ` Michael S. Tsirkin
2009-10-06  9:47   ` Rusty Russell
2009-10-01  8:28 ` [PATCH 30/34] move virtnet_remove " Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 31/34] move virtrng_remove " Uwe Kleine-König
2009-10-01  8:44   ` Christian Borntraeger
2009-10-01  8:48     ` Uwe Kleine-König
2009-10-01  9:12     ` Michael S. Tsirkin
2009-10-01  9:31       ` Uwe Kleine-König
2009-10-01  9:45         ` Michael S. Tsirkin
2009-10-01 10:17           ` Uwe Kleine-König
2009-10-01 12:32             ` Michael S. Tsirkin
2009-10-01 17:41               ` Uwe Kleine-König
2009-10-01 18:05                 ` Michael S. Tsirkin
2009-10-01 18:19                   ` Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 32/34] don't use __devexit_p to wrap zalon_remove Uwe Kleine-König
2009-10-01  8:28 ` [PATCH 33/34] move lis3l02dq_remove to .devexit.text Uwe Kleine-König
2009-10-01  9:38   ` Jonathan Cameron
2009-10-01  8:28 ` [PATCH 34/34] move sca3000_remove " Uwe Kleine-König
2009-10-01  9:39   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC54F0F.7040202@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@linux.intel.com \
    --cc=gerg@uclinux.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lsorense@csclub.uwaterloo.ca \
    --cc=sam@ravnborg.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox