From: "Éric Piel" <eric.piel@tremplin-utc.net>
To: Samu Onkalo <samu.p.onkalo@nokia.com>
Cc: akpm@linux-foundation.org, daniel@caiaq.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] LIS3LV02D_SPI: Module unload didn't remove sysfs entry
Date: Fri, 02 Oct 2009 10:01:18 +0200 [thread overview]
Message-ID: <4AC5B34E.3080903@tremplin-utc.net> (raw)
In-Reply-To: <1254399924-30921-2-git-send-email-samu.p.onkalo@nokia.com>
Op 01-10-09 14:25, Samu Onkalo schreef:
> In module unload, lis3lv02d core driver sysfs clean up was not called.
>
> Signed-off-by: Samu Onkalo <samu.p.onkalo@nokia.com>
> Acked-by: Daniel Mack <daniel@caiaq.de>
Acked-by: Éric Piel <eric.piel@tremplin-utc.net>
> ---
> drivers/hwmon/lis3lv02d_spi.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/lis3lv02d_spi.c b/drivers/hwmon/lis3lv02d_spi.c
> index ecd7395..82b1680 100644
> --- a/drivers/hwmon/lis3lv02d_spi.c
> +++ b/drivers/hwmon/lis3lv02d_spi.c
> @@ -83,7 +83,8 @@ static int __devexit lis302dl_spi_remove(struct spi_device *spi)
> struct lis3lv02d *lis3 = spi_get_drvdata(spi);
> lis3lv02d_joystick_disable();
> lis3lv02d_poweroff(lis3);
> - return 0;
> +
> + return lis3lv02d_remove_fs(&lis3_dev);
> }
>
> #ifdef CONFIG_PM
prev parent reply other threads:[~2009-10-02 8:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 12:25 [PATCH 0/1] LIS3LV02D_SPI incomplete module unloading Samu Onkalo
2009-10-01 12:25 ` [PATCH 1/1] LIS3LV02D_SPI: Module unload didn't remove sysfs entry Samu Onkalo
2009-10-02 8:01 ` Éric Piel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC5B34E.3080903@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=akpm@linux-foundation.org \
--cc=daniel@caiaq.de \
--cc=linux-kernel@vger.kernel.org \
--cc=samu.p.onkalo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox