[PATCH 0/1] LIS3LV02D_SPI incomplete module unloading

[PATCH 0/1] LIS3LV02D_SPI incomplete module unloading

[Samu Onkalo]

While implementing I2C driver for LIS3LV02D, following bug was found
from corresponding SPI implementation. This is not tested with real
HW where LIS3 is connected via SPI since I don't have one.
However, module loading and unloading is tested with dummy SPI configuration.

Patch created to top of 2.6.32-RC1

Samu Onkalo (1):
  LIS3LV02D_SPI: Module unload didn't remove sysfs entry

 drivers/hwmon/lis3lv02d_spi.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

[PATCH 1/1] LIS3LV02D_SPI: Module unload didn't remove sysfs entry

[Samu Onkalo]

In module unload, lis3lv02d core driver sysfs clean up was not called.

Signed-off-by: Samu Onkalo <samu.p.onkalo@nokia.com>
Acked-by: Daniel Mack <daniel@caiaq.de>
---
 drivers/hwmon/lis3lv02d_spi.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/hwmon/lis3lv02d_spi.c b/drivers/hwmon/lis3lv02d_spi.c
index ecd7395..82b1680 100644
--- a/drivers/hwmon/lis3lv02d_spi.c
+++ b/drivers/hwmon/lis3lv02d_spi.c
@@ -83,7 +83,8 @@ static int __devexit lis302dl_spi_remove(struct spi_device *spi)
 	struct lis3lv02d *lis3 = spi_get_drvdata(spi);
 	lis3lv02d_joystick_disable();
 	lis3lv02d_poweroff(lis3);
-	return 0;
+
+	return lis3lv02d_remove_fs(&lis3_dev);
 }
 
 #ifdef CONFIG_PM
-- 
1.5.6.3

Re: [PATCH 1/1] LIS3LV02D_SPI: Module unload didn't remove sysfs entry

[Éric Piel]

Op 01-10-09 14:25, Samu Onkalo schreef:
> In module unload, lis3lv02d core driver sysfs clean up was not called.
> 
> Signed-off-by: Samu Onkalo <samu.p.onkalo@nokia.com>
> Acked-by: Daniel Mack <daniel@caiaq.de>
Acked-by: Éric Piel <eric.piel@tremplin-utc.net>


> ---
>  drivers/hwmon/lis3lv02d_spi.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/lis3lv02d_spi.c b/drivers/hwmon/lis3lv02d_spi.c
> index ecd7395..82b1680 100644
> --- a/drivers/hwmon/lis3lv02d_spi.c
> +++ b/drivers/hwmon/lis3lv02d_spi.c
> @@ -83,7 +83,8 @@ static int __devexit lis302dl_spi_remove(struct spi_device *spi)
>  	struct lis3lv02d *lis3 = spi_get_drvdata(spi);
>  	lis3lv02d_joystick_disable();
>  	lis3lv02d_poweroff(lis3);
> -	return 0;
> +
> +	return lis3lv02d_remove_fs(&lis3_dev);
>  }
>  
>  #ifdef CONFIG_PM