Re: [PATCH] acerhdf: Limit modalias matching to supported boards

[Stefan Bader <stefan.bader@canonical.com>]

Peter Feuerer wrote:
> Borislav Petkov writes:
> 
>> On Fri, Oct 2, 2009 at 9:51 AM, Stefan Bader 
>> <stefan.bader@canonical.com> wrote:
>>>>> I search my acerhdf-inbox for the people who sent me the BIOS 
>>>>> versions,
>>>> maybe they still have the netbook and can me send the modalias 
>>>> content. I'll
>>>> hopefully find some time upcoming weekend.
>>>>
>>>> But, can't we simply assume, following dmi lines?
>>>>
>>>> MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");
>>>> MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");
>>>> MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");
>>>> MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");
>>>>
>>>> We have exactly those constellations within the BIOS settings table. 
>>>> If I
>>>> interpret the modalias line correctly, "pnAOA110" means "Product Name
>>>> AOA110" and that's what we have already in the BIOS settings table. 
>>>> So I
>>>> think we do already have all information we need to create a 
>>>> complete patch
>>>> for the problem, or am I wrong?
>>>
>>> Right pn means that. I would strongly believe the above changes 
>>> should be
>>> good. I sometimes tend to be over-cautious. Attaching a refreshed patch
>>> which includes them all.
>>
>> Well, acerhdf.c and dmi-id.c both do
>> dmi_get_system_info(DMI_PRODUCT_NAME) when querying product name which
>> means that the product names in the acerhdf table and the dmi-id ones
>> are actually one and the same thing.
>>
>> IMO, we should just go ahead send it to Len. Stefan, you have my ACK.
> 
> Will try the patch tomorrow morning and you'll then get also my ack, if 
> it's working.
> 
> --peter

Ok, cool. Will wait on that.

-Stefan

-- 

When all other means of communication fail, try words!