* [PATCH] sched: Remove obsolete comment in sched_init()
@ 2009-10-05 6:16 Jayson R. King
2009-10-05 10:02 ` Ingo Molnar
0 siblings, 1 reply; 5+ messages in thread
From: Jayson R. King @ 2009-10-05 6:16 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra; +Cc: Jiri Kosina, LKML
Remove the comment about calling alloc_bootmem() as it is not called
here since commit 36b7b6d465489c4754c4fd66fcec6086eba87896.
Signed-off-by: Jayson R. King <dev@jaysonking.com>
---
kernel/sched.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 1535f38..d68ac0e 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -9334,10 +9334,6 @@ void __init sched_init(void)
#ifdef CONFIG_CPUMASK_OFFSTACK
alloc_size += num_possible_cpus() * cpumask_size();
#endif
- /*
- * As sched_init() is called before page_alloc is setup,
- * we use alloc_bootmem().
- */
if (alloc_size) {
ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] sched: Remove obsolete comment in sched_init()
2009-10-05 6:16 [PATCH] sched: Remove obsolete comment in sched_init() Jayson R. King
@ 2009-10-05 10:02 ` Ingo Molnar
2009-10-05 10:21 ` Jayson R. King
0 siblings, 1 reply; 5+ messages in thread
From: Ingo Molnar @ 2009-10-05 10:02 UTC (permalink / raw)
To: Jayson R. King; +Cc: Peter Zijlstra, Jiri Kosina, LKML
* Jayson R. King <dev@jaysonking.com> wrote:
> Remove the comment about calling alloc_bootmem() as it is not called
> here since commit 36b7b6d465489c4754c4fd66fcec6086eba87896.
>
> Signed-off-by: Jayson R. King <dev@jaysonking.com>
> ---
> kernel/sched.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 1535f38..d68ac0e 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -9334,10 +9334,6 @@ void __init sched_init(void)
> #ifdef CONFIG_CPUMASK_OFFSTACK
> alloc_size += num_possible_cpus() * cpumask_size();
> #endif
> - /*
> - * As sched_init() is called before page_alloc is setup,
> - * we use alloc_bootmem().
> - */
> if (alloc_size) {
> ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);
Looks good. The patch is whitespace damaged though (all tabs are spaces)
- please consult Documentation/email-clients.txt and resend the patch.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] sched: Remove obsolete comment in sched_init()
2009-10-05 10:02 ` Ingo Molnar
@ 2009-10-05 10:21 ` Jayson R. King
2009-10-05 19:26 ` Jayson R. King
2009-10-05 19:39 ` [tip:sched/core] " tip-bot for Jayson R. King
0 siblings, 2 replies; 5+ messages in thread
From: Jayson R. King @ 2009-10-05 10:21 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Peter Zijlstra, Jiri Kosina, LKML
Remove the comment about calling alloc_bootmem() as it is not called
here since commit 36b7b6d465489c4754c4fd66fcec6086eba87896.
Signed-off-by: Jayson R. King <dev@jaysonking.com>
---
sched.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 1535f38..d68ac0e 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -9334,10 +9334,6 @@ void __init sched_init(void)
#ifdef CONFIG_CPUMASK_OFFSTACK
alloc_size += num_possible_cpus() * cpumask_size();
#endif
- /*
- * As sched_init() is called before page_alloc is setup,
- * we use alloc_bootmem().
- */
if (alloc_size) {
ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] sched: Remove obsolete comment in sched_init()
2009-10-05 10:21 ` Jayson R. King
@ 2009-10-05 19:26 ` Jayson R. King
2009-10-05 19:39 ` [tip:sched/core] " tip-bot for Jayson R. King
1 sibling, 0 replies; 5+ messages in thread
From: Jayson R. King @ 2009-10-05 19:26 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Peter Zijlstra, Jiri Kosina, LKML
Did that take care of the mangling?
Jayson
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:sched/core] sched: Remove obsolete comment in sched_init()
2009-10-05 10:21 ` Jayson R. King
2009-10-05 19:26 ` Jayson R. King
@ 2009-10-05 19:39 ` tip-bot for Jayson R. King
1 sibling, 0 replies; 5+ messages in thread
From: tip-bot for Jayson R. King @ 2009-10-05 19:39 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, dev, hpa, mingo, trivial, peterz, tglx, mingo
Commit-ID: cf82ff7ea7695b0e82ba07bc5e9f1bd03a74e1aa
Gitweb: http://git.kernel.org/tip/cf82ff7ea7695b0e82ba07bc5e9f1bd03a74e1aa
Author: Jayson R. King <dev@jaysonking.com>
AuthorDate: Mon, 5 Oct 2009 05:21:26 -0500
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 5 Oct 2009 21:37:22 +0200
sched: Remove obsolete comment in sched_init()
Remove the comment about calling alloc_bootmem() as it is not
called here since commit 36b7b6d465489c4754c4fd66fcec6086eba87896.
Signed-off-by: Jayson R. King <dev@jaysonking.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Jiri Kosina <trivial@kernel.org>
LKML-Reference: <4AC9C8A6.6010209@jaysonking.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/sched.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 830967e..a56446d 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -9322,10 +9322,6 @@ void __init sched_init(void)
#ifdef CONFIG_CPUMASK_OFFSTACK
alloc_size += num_possible_cpus() * cpumask_size();
#endif
- /*
- * As sched_init() is called before page_alloc is setup,
- * we use alloc_bootmem().
- */
if (alloc_size) {
ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-10-05 19:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-05 6:16 [PATCH] sched: Remove obsolete comment in sched_init() Jayson R. King
2009-10-05 10:02 ` Ingo Molnar
2009-10-05 10:21 ` Jayson R. King
2009-10-05 19:26 ` Jayson R. King
2009-10-05 19:39 ` [tip:sched/core] " tip-bot for Jayson R. King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).