From: Tejun Heo <tj@kernel.org>
To: Greg KH <greg@kroah.com>
Cc: Colin Guthrie <cguthrie@mandriva.org>,
Kay Sievers <kay.sievers@vrfy.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: get_device_parent() race bug
Date: Tue, 06 Oct 2009 10:15:12 +0900 [thread overview]
Message-ID: <4ACA9A20.4050809@kernel.org> (raw)
In-Reply-To: <20091005142201.GA21891@kroah.com>
Greg KH wrote:
>>> BUG: unable to handle kernel NULL pointer dereference at 0000000000000038
>> Ping. This one needs to be fixed in -stable. It can be triggered by
>> other char devices too.
>
> Sorry, been slowly catching up...
>
> This can be triggered by char devices? Huh? How? I don't see the
> failure path that is happening here.
Oooh, s/char/virtual/. The bug is in the path which creates a
directory under the phony parent.
> And char devices shouldn't really be using the kobject at all, except
> for a very basic reference count.
>
> I keep threatening to rip kobject out of a char device and just use a
> kref, as that is all that is really needed. Well, that and the kmap
> stuff, but again, it's not a "real" kobject being used there...
>
> Perhaps now is the time to do this.
Yay!
--
tejun
next prev parent reply other threads:[~2009-10-06 1:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 8:22 get_device_parent() race bug Tejun Heo
2009-10-04 0:35 ` Tejun Heo
2009-10-05 14:22 ` Greg KH
2009-10-06 1:15 ` Tejun Heo [this message]
2009-10-06 3:05 ` Greg KH
2009-10-06 3:29 ` Kay Sievers
2009-10-05 23:39 ` Greg KH
2009-10-06 1:35 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACA9A20.4050809@kernel.org \
--to=tj@kernel.org \
--cc=cguthrie@mandriva.org \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).