linux-next: pci tree build failure

linux-next: pci tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

Hi Jesse,

Today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: "pci_set_cacheline_size" [drivers/pcmcia/pcmcia_core.ko] undefined!

Caused by commit 018bc96e8e27bfcafec9357ff370bf51241a7ea7 ("pccard:
configure CLS on attach") which neglected to EXPORT_SYMBOL
pci_set_cacheline_size.

I have used the version of the pci tree from next-20091006 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: pci tree build failure

[Tejun Heo]

Stephen Rothwell wrote:
> Hi Jesse,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> ERROR: "pci_set_cacheline_size" [drivers/pcmcia/pcmcia_core.ko] undefined!
> 
> Caused by commit 018bc96e8e27bfcafec9357ff370bf51241a7ea7 ("pccard:
> configure CLS on attach") which neglected to EXPORT_SYMBOL
> pci_set_cacheline_size.
> 
> I have used the version of the pci tree from next-20091006 for today.
> 

Oops, Jesse, can you please add EXPORT_SYMBOL_GPL() there?

Thanks.

-- 
tejun

Re: linux-next: pci tree build failure

[Jesse Barnes]

On Wed, 07 Oct 2009 10:45:35 +0900
Tejun Heo <tj@kernel.org> wrote:

> Stephen Rothwell wrote:
> > Hi Jesse,
> > 
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> > 
> > ERROR: "pci_set_cacheline_size" [drivers/pcmcia/pcmcia_core.ko]
> > undefined!
> > 
> > Caused by commit 018bc96e8e27bfcafec9357ff370bf51241a7ea7 ("pccard:
> > configure CLS on attach") which neglected to EXPORT_SYMBOL
> > pci_set_cacheline_size.
> > 
> > I have used the version of the pci tree from next-20091006 for
> > today.
> > 
> 
> Oops, Jesse, can you please add EXPORT_SYMBOL_GPL() there?

Sure, sorry I missed it.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

linux-next: pci tree build failure

[Stephen Rothwell]

Hi Jesse,

Today's linux-next build (powerpc allyesconfig) failed like this:

In file included from drivers/pci/pcie/pme/pcie_pme.c:22:
include/linux/pci-acpi.h:42: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'acpi_find_root_bridge_handle'

You seem to have lost the patch below which I have reapplied for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 18 Jan 2010 19:36:11 +1100
Subject: [PATCH] pci: PCIE_PME seems to depend on ACPI

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/pci/pcie/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
index cf3c35f..b8b494b 100644
--- a/drivers/pci/pcie/Kconfig
+++ b/drivers/pci/pcie/Kconfig
@@ -49,4 +49,4 @@ config PCIEASPM_DEBUG
 
 config PCIE_PME
 	def_bool y
-	depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL
+	depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL && ACPI
-- 
1.6.6

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: pci tree build failure

[Jesse Barnes]

On Wed, 27 Jan 2010 17:49:00 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Jesse,
> 
> Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> In file included from drivers/pci/pcie/pme/pcie_pme.c:22:
> include/linux/pci-acpi.h:42: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'acpi_find_root_bridge_handle'
> 
> You seem to have lost the patch below which I have reapplied for today.
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 18 Jan 2010 19:36:11 +1100
> Subject: [PATCH] pci: PCIE_PME seems to depend on ACPI
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/pci/pcie/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
> index cf3c35f..b8b494b 100644
> --- a/drivers/pci/pcie/Kconfig
> +++ b/drivers/pci/pcie/Kconfig
> @@ -49,4 +49,4 @@ config PCIEASPM_DEBUG
>  
>  config PCIE_PME
>  	def_bool y
> -	depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL
> +	depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL && ACPI

Sorry about that.  Sometimes I point git in the wrong direction and it
takes of a limb or two.  Should be fixed now.

-- 
Jesse Barnes, Intel Open Source Technology Center

Re: linux-next: pci tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

Hi Jesse,

On Wed, 27 Jan 2010 09:31:13 -0800 Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>
> Sorry about that.  Sometimes I point git in the wrong direction and it
> takes of a limb or two.  Should be fixed now.

Yep, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: pci tree build failure

[Stephen Rothwell]

Hi Jesse,

Today's linux-next build (ppc64 allyesconfig) failed like this:

In file included from drivers/pci/pcie/pme/pcie_pme.c:22:
include/linux/pci-acpi.h:42: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'acpi_find_root_bridge_handle'

This file was added in commit f3adb5a4f2e1dfdf9482af05481d0928a39477e8
("PCI PM: PCIe PME root port service driver") from the pci tree and seems
to depend on ACPI.  Maybe its building should depend on CONFIG_ACPI?

I added the following patch for today (I presume there is a better fix):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 18 Jan 2010 19:36:11 +1100
Subject: [PATCH] pci: PCIE_PME seems to depend on ACPI

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/pci/pcie/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
index cf3c35f..b8b494b 100644
--- a/drivers/pci/pcie/Kconfig
+++ b/drivers/pci/pcie/Kconfig
@@ -49,4 +49,4 @@ config PCIEASPM_DEBUG
 
 config PCIE_PME
 	def_bool y
-	depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL
+	depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL && ACPI
-- 
1.6.6

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: pci tree build failure

[Rafael J. Wysocki]

On Monday 18 January 2010, Stephen Rothwell wrote:
> Hi Jesse,
> 
> Today's linux-next build (ppc64 allyesconfig) failed like this:
> 
> In file included from drivers/pci/pcie/pme/pcie_pme.c:22:
> include/linux/pci-acpi.h:42: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'acpi_find_root_bridge_handle'
> 
> This file was added in commit f3adb5a4f2e1dfdf9482af05481d0928a39477e8
> ("PCI PM: PCIe PME root port service driver") from the pci tree and seems
> to depend on ACPI.  Maybe its building should depend on CONFIG_ACPI?
> 
> I added the following patch for today (I presume there is a better fix):
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 18 Jan 2010 19:36:11 +1100
> Subject: [PATCH] pci: PCIE_PME seems to depend on ACPI
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/pci/pcie/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
> index cf3c35f..b8b494b 100644
> --- a/drivers/pci/pcie/Kconfig
> +++ b/drivers/pci/pcie/Kconfig
> @@ -49,4 +49,4 @@ config PCIEASPM_DEBUG
>  
>  config PCIE_PME
>  	def_bool y
> -	depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL
> +	depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL && ACPI

Thanks a lot, this is the right fix IMO.

Jesse, do you want me to resend the patch with this fix included or are you
going to take the Stephens patch to your tree?

Rafael

Re: linux-next: pci tree build failure

[Jesse Barnes]

On Mon, 18 Jan 2010 22:24:44 +0100
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> On Monday 18 January 2010, Stephen Rothwell wrote:
> > Hi Jesse,
> > 
> > Today's linux-next build (ppc64 allyesconfig) failed like this:
> > 
> > In file included from drivers/pci/pcie/pme/pcie_pme.c:22:
> > include/linux/pci-acpi.h:42: error: expected '=', ',', ';', 'asm'
> > or '__attribute__' before 'acpi_find_root_bridge_handle'
> > 
> > This file was added in commit
> > f3adb5a4f2e1dfdf9482af05481d0928a39477e8 ("PCI PM: PCIe PME root
> > port service driver") from the pci tree and seems to depend on
> > ACPI.  Maybe its building should depend on CONFIG_ACPI?
> > 
> > I added the following patch for today (I presume there is a better
> > fix):
> > 
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Mon, 18 Jan 2010 19:36:11 +1100
> > Subject: [PATCH] pci: PCIE_PME seems to depend on ACPI
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  drivers/pci/pcie/Kconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
> > index cf3c35f..b8b494b 100644
> > --- a/drivers/pci/pcie/Kconfig
> > +++ b/drivers/pci/pcie/Kconfig
> > @@ -49,4 +49,4 @@ config PCIEASPM_DEBUG
> >  
> >  config PCIE_PME
> >  	def_bool y
> > -	depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL
> > +	depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL &&
> > ACPI
> 
> Thanks a lot, this is the right fix IMO.
> 
> Jesse, do you want me to resend the patch with this fix included or
> are you going to take the Stephens patch to your tree?

I'll pull in Stephen's fix, thanks.

Jesse

Re: linux-next: pci tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

Hi all,

On Tue, 19 Jan 2010 02:35:34 +0000 Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>
> On Mon, 18 Jan 2010 22:24:44 +0100 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> > 
> > Thanks a lot, this is the right fix IMO.
> > 
> > Jesse, do you want me to resend the patch with this fix included or
> > are you going to take the Stephens patch to your tree?
> 
> I'll pull in Stephen's fix, thanks.

OK, thanks.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: pci tree build failure

[Jesse Barnes]

Pushed this fix out to linux-next, thanks.

Jesse

On Mon, 18 Jan 2010 19:40:50 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Jesse,
> 
> Today's linux-next build (ppc64 allyesconfig) failed like this:
> 
> In file included from drivers/pci/pcie/pme/pcie_pme.c:22:
> include/linux/pci-acpi.h:42: error: expected '=', ',', ';', 'asm' or
> '__attribute__' before 'acpi_find_root_bridge_handle'
> 
> This file was added in commit f3adb5a4f2e1dfdf9482af05481d0928a39477e8
> ("PCI PM: PCIe PME root port service driver") from the pci tree and
> seems to depend on ACPI.  Maybe its building should depend on
> CONFIG_ACPI?
> 
> I added the following patch for today (I presume there is a better
> fix):
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 18 Jan 2010 19:36:11 +1100
> Subject: [PATCH] pci: PCIE_PME seems to depend on ACPI
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/pci/pcie/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
> index cf3c35f..b8b494b 100644
> --- a/drivers/pci/pcie/Kconfig
> +++ b/drivers/pci/pcie/Kconfig
> @@ -49,4 +49,4 @@ config PCIEASPM_DEBUG
>  
>  config PCIE_PME
>  	def_bool y
> -	depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL
> +	depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL && ACPI

Re: linux-next: pci tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

Hi Jesse,

On Wed, 20 Jan 2010 06:39:32 +0200 Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>
> Pushed this fix out to linux-next, thanks.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: pci tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

Hi Jesse,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/pci/hotplug/rpaphp_core.c:433: error: unknown field 'get_max_bus_speed' specified in initializer
drivers/pci/hotplug/rpaphp_core.c:433: warning: excess elements in struct initializer
drivers/pci/hotplug/rpaphp_core.c:433: warning: (near initialization for 'rpaphp_hotplug_slot_ops')

Caused by commit 7227d60c98ad0e1af49c717a62515d74002dd754 ("PCI: Make
current and maximum bus speeds part of the PCI core").

I have used the version of the pci tree from next-20100104 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: pci tree build failure

[Matthew Wilcox]

On Tue, Jan 05, 2010 at 09:55:43AM +1100, Stephen Rothwell wrote:
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> drivers/pci/hotplug/rpaphp_core.c:433: error: unknown field 'get_max_bus_speed' specified in initializer
> drivers/pci/hotplug/rpaphp_core.c:433: warning: excess elements in struct initializer
> drivers/pci/hotplug/rpaphp_core.c:433: warning: (near initialization for 'rpaphp_hotplug_slot_ops')
> 
> Caused by commit 7227d60c98ad0e1af49c717a62515d74002dd754 ("PCI: Make
> current and maximum bus speeds part of the PCI core").
> 
> I have used the version of the pci tree from next-20100104 for today.

Doh, sorry.  I don't have a handy powerpc environment around to test with.
Can you try just deleting line 433?  (this should actually be the correct fix).

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

Re: linux-next: pci tree build failure

[Jesse Barnes]

On Mon, 4 Jan 2010 16:10:01 -0700
Matthew Wilcox <matthew@wil.cx> wrote:

> On Tue, Jan 05, 2010 at 09:55:43AM +1100, Stephen Rothwell wrote:
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> > 
> > drivers/pci/hotplug/rpaphp_core.c:433: error: unknown field
> > 'get_max_bus_speed' specified in initializer
> > drivers/pci/hotplug/rpaphp_core.c:433: warning: excess elements in
> > struct initializer drivers/pci/hotplug/rpaphp_core.c:433: warning:
> > (near initialization for 'rpaphp_hotplug_slot_ops')
> > 
> > Caused by commit 7227d60c98ad0e1af49c717a62515d74002dd754 ("PCI:
> > Make current and maximum bus speeds part of the PCI core").
> > 
> > I have used the version of the pci tree from next-20100104 for
> > today.
> 
> Doh, sorry.  I don't have a handy powerpc environment around to test
> with. Can you try just deleting line 433?  (this should actually be
> the correct fix).

I just pushed that into my linux-next tree.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

Re: linux-next: pci tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

Hi Jesse,

On Mon, 4 Jan 2010 15:48:43 -0800 Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>
> > Doh, sorry.  I don't have a handy powerpc environment around to test
> > with. Can you try just deleting line 433?  (this should actually be
> > the correct fix).
> 
> I just pushed that into my linux-next tree.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: pci tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

Hi Jesse,

Today's linux-next build (x86_64 allmodconfig) failed like this:

arch/x86/pci/common.c:619: error: expected '}' before ';' token

Caused by commit 1c6804b093f5753c2a23aa36f31f66966035bd32 ("x86/PCI:
initialize PCI bus node numbers early").  This could not have been built
with CONFIG_NUMA set ...

I have used the version of the pci tree from next-20090714 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: pci tree build failure

[Jesse Barnes]

On Wed, 15 Jul 2009 11:45:10 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Jesse,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> arch/x86/pci/common.c:619: error: expected '}' before ';' token
> 
> Caused by commit 1c6804b093f5753c2a23aa36f31f66966035bd32 ("x86/PCI:
> initialize PCI bus node numbers early").  This could not have been
> built with CONFIG_NUMA set ...
> 
> I have used the version of the pci tree from next-20090714 for today.

Arg, did I apply the patch w/o that fix?  Fixing now...

-- 
Jesse Barnes, Intel Open Source Technology Center

Re: linux-next: pci tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

Hi Jesse,

On Wed, 15 Jul 2009 09:09:13 -0700 Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>
> Arg, did I apply the patch w/o that fix?  Fixing now...

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: pci tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

Hi Jesse,

Today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: "pci_claim_resource" [drivers/pcmcia/yenta_socket.ko] undefined!

Caused by commit 6bb04b65dbff5a5bb01617351dbb0af577084752 ("yenta: Use
pci_claim_resource").  yenta can be built as a module, but
pci_claim_resource is not exported ...

I have used the pci tree from next-20090629 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: pci tree build failure

[Jesse Barnes]

On Tue, 30 Jun 2009 12:07:27 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Jesse,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> ERROR: "pci_claim_resource" [drivers/pcmcia/yenta_socket.ko]
> undefined!
> 
> Caused by commit 6bb04b65dbff5a5bb01617351dbb0af577084752 ("yenta: Use
> pci_claim_resource").  yenta can be built as a module, but
> pci_claim_resource is not exported ...
> 
> I have used the pci tree from next-20090629 for today.

Damn, thought I built that.  linux-next earns its keep yet again.

-- 
Jesse Barnes, Intel Open Source Technology Center

Re: linux-next: pci tree build failure

[Matthew Wilcox]

On Mon, Jun 29, 2009 at 07:13:24PM -0700, Jesse Barnes wrote:
> On Tue, 30 Jun 2009 12:07:27 +1000
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Hi Jesse,
> > 
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> > 
> > ERROR: "pci_claim_resource" [drivers/pcmcia/yenta_socket.ko]
> > undefined!
> > 
> > Caused by commit 6bb04b65dbff5a5bb01617351dbb0af577084752 ("yenta: Use
> > pci_claim_resource").  yenta can be built as a module, but
> > pci_claim_resource is not exported ...
> > 
> > I have used the pci tree from next-20090629 for today.
> 
> Damn, thought I built that.  linux-next earns its keep yet again.

Sorry about that.  I thought I'd checked that.  Must have been confused
with another function.  There do seem to be legitimate *drivers*
that could use it (i2o for one), so I propose making it a full-bodied
'EXPORT_SYMBOL' and not bother with the _GPL tag.  Thoughts?

Re: linux-next: pci tree build failure

[Jesse Barnes]

On Mon, 29 Jun 2009 19:24:53 -0700
Matthew Wilcox <willy@linux.intel.com> wrote:

> On Mon, Jun 29, 2009 at 07:13:24PM -0700, Jesse Barnes wrote:
> > On Tue, 30 Jun 2009 12:07:27 +1000
> > Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > > Hi Jesse,
> > > 
> > > Today's linux-next build (x86_64 allmodconfig) failed like this:
> > > 
> > > ERROR: "pci_claim_resource" [drivers/pcmcia/yenta_socket.ko]
> > > undefined!
> > > 
> > > Caused by commit 6bb04b65dbff5a5bb01617351dbb0af577084752
> > > ("yenta: Use pci_claim_resource").  yenta can be built as a
> > > module, but pci_claim_resource is not exported ...
> > > 
> > > I have used the pci tree from next-20090629 for today.
> > 
> > Damn, thought I built that.  linux-next earns its keep yet again.
> 
> Sorry about that.  I thought I'd checked that.  Must have been
> confused with another function.  There do seem to be legitimate
> *drivers* that could use it (i2o for one), so I propose making it a
> full-bodied 'EXPORT_SYMBOL' and not bother with the _GPL tag.
> Thoughts?

Fine by me; that matches most of the PCI core (though the slots bits
are _GPL).

-- 
Jesse Barnes, Intel Open Source Technology Center