Re: [PATCH 1/4] virtio_blk: deprecate the 1024-byte ID field.

john cooper
2009-10-07T05:57:09Z

Rusty Russell wrote:
> Also, I've been convinced to just hand over the 20 byte serial number
> since we're revisiting this. It's simple, and there's no clear consensus.

I'm fine with this approach as it is where
I originally started with this Sisyphus Patch.
My bias toward pressing the ATA identify
interface into service here was just to reuse
an existing interface and make life easier
from the perspective of the guest.

On the subject of retrieving the S/N alone, this
is the form of the simplistic ioctl originally
used to do so:

unsigned char sn[80];
:
sn[0] = sizeof(sn);
ioctl(fd, VBLK_GET_SN, &sn);

-john

--
john.cooper@redhat.com