From: "Éric Piel" <eric.piel@tremplin-utc.net>
To: Jonathan Cameron <Jonathan.Cameron@gmail.com>
Cc: Samu Onkalo <samu.p.onkalo@nokia.com>,
linux-kernel@vger.kernel.org,
LM Sensors <lm-sensors@lm-sensors.org>,
"Trisal, Kalhan" <kalhan.trisal@intel.com>,
Jean Delvare <khali@linux-fr.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][PATCH 0/2] LIS3LV02D I2C driver
Date: Wed, 07 Oct 2009 19:01:11 +0200 [thread overview]
Message-ID: <4ACCC957.3060802@tremplin-utc.net> (raw)
In-Reply-To: <4ACCC273.1030308@gmail.com>
Op 07-10-09 18:31, Jonathan Cameron schreef:
> Just a quick heads up wrt overlapping work.
>
> For the i2c support Kalhan Trisal has been posting patches for i2c
> support for this
> driver to the lm-sensors list for some time and the latest version of that
> set is also pretty clean.
You mean this post, right?
http://lists.lm-sensors.org/pipermail/lm-sensors/2009-August/026505.html
"Accelerometer driver for STMicroeletronics-LIS331DL-three-axis-digital"
Thanks for the heads up, I had never heard of this driver before.
Well, it's for the LIS331DL, not the LIS3LV02DL (12 bits) or the
LIS302DL (8 bits) (both supported by lis3lv02d driver). That said,
according to the specs, it seems to be _very_ similar to the LIS302DL,
they even report the same "who_am_i" value. Just some special features
are different (free fall detection for instance).
>
> The changes in these two patch sets should probably be reconciled before
> merging.
Yes, at least from a 5 minutes look, it seems it should be possible to
merge both drivers. Samu's i2c implementation is pretty clean as well
and IMHO it seems the Right Thing to have all the bus specific parts
(I²C, SPI, ACPI/HP) "inheriting" from a generic driver. So I think we
should try to merge everything in the lis3lv02d driver. Kalhan, would
you mind having a look at the patch from Samu, and see what is required
to get your LIS331DL working with the lis3lv02d driver? It should be
very little and avoid duplication of efforts :-)
See you,
Eric
next prev parent reply other threads:[~2009-10-07 17:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 10:06 [RFC][PATCH 0/2] LIS3LV02D I2C driver Samu Onkalo
2009-10-01 10:06 ` [PATCH 1/2] LIS3LV02D: axis remap, irq and resource setup / release added to platform data Samu Onkalo
2009-10-01 10:06 ` [PATCH 2/2] LIS3LV02D: I2C support Samu Onkalo
2009-10-02 8:20 ` Éric Piel
2009-10-07 16:31 ` [RFC][PATCH 0/2] LIS3LV02D I2C driver Jonathan Cameron
2009-10-07 17:01 ` Éric Piel [this message]
2009-10-07 17:20 ` Jonathan Cameron
2009-10-07 17:26 ` Éric Piel
2009-10-13 10:13 ` Onkalo Samu
2009-10-13 10:20 ` Trisal, Kalhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACCC957.3060802@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=Jonathan.Cameron@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kalhan.trisal@intel.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=samu.p.onkalo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox