From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932428AbZJHQCa (ORCPT ); Thu, 8 Oct 2009 12:02:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754289AbZJHQC3 (ORCPT ); Thu, 8 Oct 2009 12:02:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43199 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbZJHQC3 (ORCPT ); Thu, 8 Oct 2009 12:02:29 -0400 Message-ID: <4ACE0CF3.7090101@redhat.com> Date: Thu, 08 Oct 2009 18:01:55 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Thunderbird/3.0b3 MIME-Version: 1.0 To: Joerg Roedel CC: Marcelo Tosatti , Alexander Graf , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/9] KVM: SVM: Add tracepoint for invlpga instruction References: <1254996199-17667-1-git-send-email-joerg.roedel@amd.com> <1254996199-17667-8-git-send-email-joerg.roedel@amd.com> In-Reply-To: <1254996199-17667-8-git-send-email-joerg.roedel@amd.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/2009 12:03 PM, Joerg Roedel wrote: > This patch adds a tracepoint for the event that the guest > executed the INVLPGA instruction. > + > + TP_printk("rip=0x%016llx asid=%d adress=0x%016llx\n", > + __entry->rip, __entry->asid, __entry->address) > +); > s/adress/address/. Also, kvm tracepoints don't use '=' in TP_printk(), please keep it consistent. Yeah, I know, but I don't have any real comments to make. -- error compiling committee.c: too many arguments to function