From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934420AbZJIVQi (ORCPT ); Fri, 9 Oct 2009 17:16:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761418AbZJIVQh (ORCPT ); Fri, 9 Oct 2009 17:16:37 -0400 Received: from claw.goop.org ([74.207.240.146]:42643 "EHLO claw.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761416AbZJIVQf (ORCPT ); Fri, 9 Oct 2009 17:16:35 -0400 Message-ID: <4ACFA80E.7050701@goop.org> Date: Fri, 09 Oct 2009 14:15:58 -0700 From: Jeremy Fitzhardinge User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4 MIME-Version: 1.0 To: Andi Kleen CC: Ingo Molnar , Linux Kernel Mailing List , the arch/x86 maintainers Subject: Duplication of vdso and vsyscall code? X-Enigmail-Version: 0.97a Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org arch/x86/kernel/vsyscall_64.c implements vgettimeofday and vgetcpu. (And vtime) arch/x86/vdso/vclock_gettime.c implements __vdso_gettimeofday (and __vdso_clock_gettime), and vgetcpu.c has __vdso_getcpu. These appear to be functionally identical duplicate definitions. I don't understand the history here to know how we came to get two sets of these functions, but surely we can share the same code for both of these? Thanks, J