From: Masami Hiramatsu <mhiramat@redhat.com>
To: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
anil.s.keshavamurthy@intel.com, davem@davemloft.net,
ananth@in.ibm.com, tglx@linutronix.de, mhiramat@redhat.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/cleanups] x86: use kernel_stack_pointer() in kprobes.c
Date: Mon, 12 Oct 2009 17:35:57 -0400 [thread overview]
Message-ID: <4AD3A13D.2090906@redhat.com> (raw)
In-Reply-To: <tip-98272ed0d2e6509fe7dc571e77956c99bf653bb6@git.kernel.org>
tip-bot for H. Peter Anvin wrote:
> Commit-ID: 98272ed0d2e6509fe7dc571e77956c99bf653bb6
> Gitweb: http://git.kernel.org/tip/98272ed0d2e6509fe7dc571e77956c99bf653bb6
> Author: H. Peter Anvin<hpa@zytor.com>
> AuthorDate: Mon, 12 Oct 2009 14:14:10 -0700
> Committer: H. Peter Anvin<hpa@zytor.com>
> CommitDate: Mon, 12 Oct 2009 14:19:35 -0700
>
> x86: use kernel_stack_pointer() in kprobes.c
>
> The way to obtain a kernel-mode stack pointer from a struct pt_regs in
> 32-bit mode is "subtle": the stack doesn't actually contain the stack
> pointer, but rather the location where it would have been marks the
> actual previous stack frame. For clarity, use kernel_stack_pointer()
> instead of coding this weirdness explicitly.
>
> Signed-off-by: H. Peter Anvin<hpa@zytor.com>
> Cc: Ananth N Mavinakayanahalli<ananth@in.ibm.com>
> Cc: Anil S Keshavamurthy<anil.s.keshavamurthy@intel.com>
> Cc: "David S. Miller"<davem@davemloft.net>
> Cc: Masami Hiramatsu<mhiramat@redhat.com>
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
Thank you for fixing it!
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
parent reply other threads:[~2009-10-12 21:32 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <tip-98272ed0d2e6509fe7dc571e77956c99bf653bb6@git.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD3A13D.2090906@redhat.com \
--to=mhiramat@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox