* [PATCH] tracing/filters: Fix memory leak when setting a filter
@ 2009-10-13 1:28 Li Zefan
2009-10-13 6:14 ` [tip:tracing/urgent] " tip-bot for Li Zefan
0 siblings, 1 reply; 2+ messages in thread
From: Li Zefan @ 2009-10-13 1:28 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Steven Rostedt, Frederic Weisbecker, Tom Zanussi, LKML
Every time we set a filter, we leak memory allocated by
postfix_append_operand() and postfix_append_op().
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
kernel/trace/trace_events_filter.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index 2324578..98a6cc5 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -933,8 +933,9 @@ static void postfix_clear(struct filter_parse_state *ps)
while (!list_empty(&ps->postfix)) {
elt = list_first_entry(&ps->postfix, struct postfix_elt, list);
- kfree(elt->operand);
list_del(&elt->list);
+ kfree(elt->operand);
+ kfree(elt);
}
}
--
1.6.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* [tip:tracing/urgent] tracing/filters: Fix memory leak when setting a filter
2009-10-13 1:28 [PATCH] tracing/filters: Fix memory leak when setting a filter Li Zefan
@ 2009-10-13 6:14 ` tip-bot for Li Zefan
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Li Zefan @ 2009-10-13 6:14 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, tzanussi, lizf, fweisbec, rostedt, tglx,
mingo
Commit-ID: 8ad807318fcd62aba0e18c7c7fbfcc1af3fcdbab
Gitweb: http://git.kernel.org/tip/8ad807318fcd62aba0e18c7c7fbfcc1af3fcdbab
Author: Li Zefan <lizf@cn.fujitsu.com>
AuthorDate: Tue, 13 Oct 2009 09:28:57 +0800
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 13 Oct 2009 08:05:17 +0200
tracing/filters: Fix memory leak when setting a filter
Every time we set a filter, we leak memory allocated by
postfix_append_operand() and postfix_append_op().
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
Cc: <stable@kernel.org> # for v2.6.31.x
LKML-Reference: <4AD3D7D9.4070400@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/trace/trace_events_filter.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index 2324578..98a6cc5 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -933,8 +933,9 @@ static void postfix_clear(struct filter_parse_state *ps)
while (!list_empty(&ps->postfix)) {
elt = list_first_entry(&ps->postfix, struct postfix_elt, list);
- kfree(elt->operand);
list_del(&elt->list);
+ kfree(elt->operand);
+ kfree(elt);
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-13 6:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-13 1:28 [PATCH] tracing/filters: Fix memory leak when setting a filter Li Zefan
2009-10-13 6:14 ` [tip:tracing/urgent] " tip-bot for Li Zefan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox