From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
josh@joshtriplett.org, dvhltc@us.ibm.com, niv@us.ibm.com,
tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org,
Valdis.Kletnieks@vt.edu, dhowells@redhat.com, avi@redhat.com,
mtosatti@redhat.com, torvalds@linux-foundation.org
Subject: Re: [PATCH RFC tip/core/rcu 1/3] rcu: The Bloatwatch Edition, v7
Date: Tue, 13 Oct 2009 14:05:15 +0800 [thread overview]
Message-ID: <4AD4189B.2000308@cn.fujitsu.com> (raw)
In-Reply-To: <20091012173006.GC6764@linux.vnet.ibm.com>
Paul E. McKenney wrote:
> Hmmmm... Does this apply even when called from ksoftirqd?
>
> Adding the local_irq_save() just out of paranoia for the moment.
> And therefore moving the local_irq_save() down to the common
> rcu_qsctr_help() function. Which I am renaming to rcu_qs_help()
> for consistency.
>
> Or am I missing something here?
>
You are right! local_irq_save() is needed.
Lai
next prev parent reply other threads:[~2009-10-13 6:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 22:49 [PATCH RFC tip/core/rcu 0/3] Tiny RCU and expedited SRCU Paul E. McKenney
2009-10-09 22:50 ` [PATCH RFC tip/core/rcu 1/3] rcu: The Bloatwatch Edition, v7 Paul E. McKenney
2009-10-12 9:29 ` Lai Jiangshan
2009-10-12 16:40 ` Linus Torvalds
2009-10-12 17:30 ` Paul E. McKenney
2009-10-13 6:05 ` Lai Jiangshan [this message]
2009-10-13 7:44 ` Lai Jiangshan
2009-10-13 17:00 ` Paul E. McKenney
2009-10-14 0:37 ` Lai Jiangshan
2009-10-14 1:09 ` Paul E. McKenney
2009-10-14 2:05 ` Lai Jiangshan
2009-10-14 2:49 ` Steven Rostedt
2009-10-27 7:26 ` Lai Jiangshan
2009-10-27 19:56 ` Steven Rostedt
2009-10-14 2:52 ` Paul E. McKenney
2009-10-09 22:50 ` [PATCH RFC tip/core/rcu 2/3] rcu: Add synchronize_srcu_expedited() Paul E. McKenney
2009-10-09 22:50 ` [PATCH RFC tip/core/rcu 3/3] rcu: add synchronize_srcu_expedited() to the rcutorture test suite Paul E. McKenney
2009-10-10 3:47 ` [PATCH RFC tip/core/rcu 0/3] Tiny RCU and expedited SRCU Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD4189B.2000308@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox