Re: [GIT PULL] tracing/kprobes: Syntax updates, introduce perf probe

[Masami Hiramatsu <mhiramat@redhat.com>]

Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
>>>  tools/perf/Makefile                 |   10 +
>>>  tools/perf/builtin-probe.c          |  386 +++++++++++++++++++
>>>  tools/perf/builtin.h                |    1 +
>>>  tools/perf/perf.c                   |    1 +
>>>  tools/perf/util/probe-finder.c      |  690 +++++++++++++++++++++++++++++++++++
>>>  tools/perf/util/probe-finder.h      |   70 ++++
>>>  8 files changed, 1271 insertions(+), 74 deletions(-)
>>>  create mode 100644 tools/perf/builtin-probe.c
>>>  create mode 100644 tools/perf/util/probe-finder.c
>>>  create mode 100644 tools/perf/util/probe-finder.h
>>
>> Hm, there's no x86 decoder change here - does this lot fixes the 
>> instruction decoder bug i reported some time ago? That is which keeps 
>> tracing/kprobes out of tip:master.
> 
> See my previous report below.
> 
> 	Ingo
> 
> ----- Forwarded message from Ingo Molnar <mingo@elte.hu> -----
> 
> Date: Sat, 3 Oct 2009 12:49:23 +0200
> From: Ingo Molnar <mingo@elte.hu>
> To: Frederic Weisbecker <fweisbec@gmail.com>
> Subject: Re: [GIT PULL] tracing/kprobes: kprobes fixes
> Cc: LKML <linux-kernel@vger.kernel.org>,
> 	Steven Rostedt <rostedt@goodmis.org>,
> 	Li Zefan <lizf@cn.fujitsu.com>
> 
> 
> ok, -tip testing found this new failure:
> 
>   TEST    posttest
> Error: ffffffff8106ac00:        66 0f 73 fd 04          pslldq $0x4,%xmm5
> Error: objdump says 5 bytes, but insn_get_length() says 4 (attr:8000)
> make[1]: *** [posttest] Error 2
> make: *** [bzImage] Error 2
> 
> 	Ingo
> 

Hmm, thank you for reporting, I've missed some group opcode...

Thank you again,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com