From: Gregory Haskins <ghaskins@novell.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -mm]: vbus: Fix section mismatch warnings in pci-bridge.c
Date: Tue, 13 Oct 2009 09:40:52 -0400 [thread overview]
Message-ID: <4AD48364.4000807@novell.com> (raw)
In-Reply-To: <b9df5fa10910111808p424bba2bu999a7a49f32cc3d0@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2041 bytes --]
Rakib Mullick wrote:
> The functions vbus_pci_open, _ioq_init, eventq_init,
> vbus_pci_eventq_register are
> annoted with __init and referenced from a function __devinit
> vbus_pci_probe, which
> causes a section mismatch.So annote those functions with __devinit.
>
> We were warned by the following warnings:
>
> LD drivers/vbus/vbus-pcibridge.o
> WARNING: drivers/vbus/vbus-pcibridge.o(.devinit.text+0x19e): Section
> mismatch in reference from the function vbus_pci_probe() to the
> function .init.text:vbus_pci_open()
> The function __devinit vbus_pci_probe() references
> a function __init vbus_pci_open().
> If vbus_pci_open is only used by vbus_pci_probe then
> annotate vbus_pci_open with a matching annotation.
>
> WARNING: drivers/vbus/vbus-pcibridge.o(.devinit.text+0x1f4): Section
> mismatch in reference from the function vbus_pci_probe() to the
> function .init.text:_ioq_init()
> The function __devinit vbus_pci_probe() references
> a function __init _ioq_init().
> If _ioq_init is only used by vbus_pci_probe then
> annotate _ioq_init with a matching annotation.
>
> WARNING: drivers/vbus/vbus-pcibridge.o(.devinit.text+0x240): Section
> mismatch in reference from the function vbus_pci_probe() to the
> function .init.text:eventq_init()
> The function __devinit vbus_pci_probe() references
> a function __init eventq_init().
> If eventq_init is only used by vbus_pci_probe then
> annotate eventq_init with a matching annotation.
>
> WARNING: drivers/vbus/vbus-pcibridge.o(.devinit.text+0x45a): Section
> mismatch in reference from the function vbus_pci_probe() to the
> function .init.text:vbus_pci_eventq_register()
> The function __devinit vbus_pci_probe() references
> a function __init vbus_pci_eventq_register().
> If vbus_pci_eventq_register is only used by vbus_pci_probe then
> annotate vbus_pci_eventq_register with a matching annotation.
>
> ---
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
Applied Rakib, thanks.
Kind Regards,
-Greg
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 267 bytes --]
prev parent reply other threads:[~2009-10-13 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 1:08 [PATCH -mm]: vbus: Fix section mismatch warnings in pci-bridge.c Rakib Mullick
2009-10-13 13:40 ` Gregory Haskins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD48364.4000807@novell.com \
--to=ghaskins@novell.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox