[PATCH -mm]: vbus: Fix section mismatch warnings in pci-bridge.c

[PATCH -mm]: vbus: Fix section mismatch warnings in pci-bridge.c

[Rakib Mullick]

 The functions vbus_pci_open, _ioq_init, eventq_init,
vbus_pci_eventq_register are
annoted with __init and referenced from a function __devinit
vbus_pci_probe, which
causes a section mismatch.So annote those functions with __devinit.

 We were warned by the following warnings:

  LD      drivers/vbus/vbus-pcibridge.o
WARNING: drivers/vbus/vbus-pcibridge.o(.devinit.text+0x19e): Section
mismatch in reference from the function vbus_pci_probe() to the
function .init.text:vbus_pci_open()
The function __devinit vbus_pci_probe() references
a function __init vbus_pci_open().
If vbus_pci_open is only used by vbus_pci_probe then
annotate vbus_pci_open with a matching annotation.

WARNING: drivers/vbus/vbus-pcibridge.o(.devinit.text+0x1f4): Section
mismatch in reference from the function vbus_pci_probe() to the
function .init.text:_ioq_init()
The function __devinit vbus_pci_probe() references
a function __init _ioq_init().
If _ioq_init is only used by vbus_pci_probe then
annotate _ioq_init with a matching annotation.

WARNING: drivers/vbus/vbus-pcibridge.o(.devinit.text+0x240): Section
mismatch in reference from the function vbus_pci_probe() to the
function .init.text:eventq_init()
The function __devinit vbus_pci_probe() references
a function __init eventq_init().
If eventq_init is only used by vbus_pci_probe then
annotate eventq_init with a matching annotation.

WARNING: drivers/vbus/vbus-pcibridge.o(.devinit.text+0x45a): Section
mismatch in reference from the function vbus_pci_probe() to the
function .init.text:vbus_pci_eventq_register()
The function __devinit vbus_pci_probe() references
a function __init vbus_pci_eventq_register().
If vbus_pci_eventq_register is only used by vbus_pci_probe then
annotate vbus_pci_eventq_register with a matching annotation.

---
Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>

--- linus/drivers/vbus/pci-bridge.c	2009-10-11 23:38:51.000000000 +0600
+++ rakib/drivers/vbus/pci-bridge.c	2009-10-11 23:46:52.000000000 +0600
@@ -478,7 +478,7 @@ event_shmclose(struct vbus_pci_handle_ev

 static struct ioq_notifier eventq_notifier;

-static int __init
+static int __devinit
 eventq_init(int qlen)
 {
 	struct ioq_iterator iter;
@@ -687,7 +687,7 @@ vbus_pci_release(void)
 	vbus_pci.enabled = false;
 }

-static int __init
+static int __devinit
 vbus_pci_open(void)
 {
 	struct vbus_pci_bridge_negotiate params = {
@@ -702,7 +702,7 @@ vbus_pci_open(void)

 #define QLEN 1024

-static int __init
+static int __devinit
 vbus_pci_eventq_register(void)
 {
 	struct vbus_pci_busreg params = {
@@ -720,7 +720,7 @@ vbus_pci_eventq_register(void)
 				   &params, sizeof(params));
 }

-static int __init
+static int __devinit
 _ioq_init(size_t ringsize, struct ioq *ioq, struct ioq_ops *ops)
 {
 	struct shm_signal    *signal = NULL;

Re: [PATCH -mm]: vbus: Fix section mismatch warnings in pci-bridge.c

[Gregory Haskins]

[-- Attachment #1: Type: text/plain, Size: 2041 bytes --]

Rakib Mullick wrote:
>  The functions vbus_pci_open, _ioq_init, eventq_init,
> vbus_pci_eventq_register are
> annoted with __init and referenced from a function __devinit
> vbus_pci_probe, which
> causes a section mismatch.So annote those functions with __devinit.
> 
>  We were warned by the following warnings:
> 
>   LD      drivers/vbus/vbus-pcibridge.o
> WARNING: drivers/vbus/vbus-pcibridge.o(.devinit.text+0x19e): Section
> mismatch in reference from the function vbus_pci_probe() to the
> function .init.text:vbus_pci_open()
> The function __devinit vbus_pci_probe() references
> a function __init vbus_pci_open().
> If vbus_pci_open is only used by vbus_pci_probe then
> annotate vbus_pci_open with a matching annotation.
> 
> WARNING: drivers/vbus/vbus-pcibridge.o(.devinit.text+0x1f4): Section
> mismatch in reference from the function vbus_pci_probe() to the
> function .init.text:_ioq_init()
> The function __devinit vbus_pci_probe() references
> a function __init _ioq_init().
> If _ioq_init is only used by vbus_pci_probe then
> annotate _ioq_init with a matching annotation.
> 
> WARNING: drivers/vbus/vbus-pcibridge.o(.devinit.text+0x240): Section
> mismatch in reference from the function vbus_pci_probe() to the
> function .init.text:eventq_init()
> The function __devinit vbus_pci_probe() references
> a function __init eventq_init().
> If eventq_init is only used by vbus_pci_probe then
> annotate eventq_init with a matching annotation.
> 
> WARNING: drivers/vbus/vbus-pcibridge.o(.devinit.text+0x45a): Section
> mismatch in reference from the function vbus_pci_probe() to the
> function .init.text:vbus_pci_eventq_register()
> The function __devinit vbus_pci_probe() references
> a function __init vbus_pci_eventq_register().
> If vbus_pci_eventq_register is only used by vbus_pci_probe then
> annotate vbus_pci_eventq_register with a matching annotation.
> 
> ---
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>

Applied Rakib, thanks.

Kind Regards,
-Greg


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 267 bytes --]