From: Jeff Mahoney <jeffm@suse.com>
To: Valdis.Kletnieks@vt.edu
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Roman Zippel andr <zippel@linux-m68k.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] hfs: fix oops on mount with corrupted btree extent records
Date: Tue, 13 Oct 2009 10:13:10 -0400 [thread overview]
Message-ID: <4AD48AF6.1010700@suse.com> (raw)
In-Reply-To: <14762.1255407123@turing-police.cc.vt.edu>
On 10/13/2009 12:12 AM, Valdis.Kletnieks@vt.edu wrote:
> On Mon, 12 Oct 2009 20:41:37 EDT, Jeff Mahoney said:
>> A particular fsfuzzer run caused an hfs file system to crash on mount. This
>> is due to a corrupted MDB extent record causing a miscalculation of
>> HFS_I(inode)->first_blocks for the extent tree. If the extent records
>> are zereod out, it won't trigger the first_blocks special case. Instead
>> it falls through to the extent code which we're still in the middle
>> of initializing.
>>
>> This patch catches the 0 size extent records, reports the corruption,
>> and fails the mount.
>
> Just for completeness - does the current fsck.hfs already know how to fix it, or
> at least heave stuff over the side so the filesystem is self-consistent again?
> Or will a user who hits this need a new fsck.hfs to get it back to mountable?
Sorry, I don't actually know. We don't ship a fsck.hfs so I haven't
tested it.
-Jeff
--
Jeff Mahoney
SUSE Labs
prev parent reply other threads:[~2009-10-13 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 0:41 [PATCH] hfs: fix oops on mount with corrupted btree extent records Jeff Mahoney
2009-10-13 4:12 ` Valdis.Kletnieks
2009-10-13 14:13 ` Jeff Mahoney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD48AF6.1010700@suse.com \
--to=jeffm@suse.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox