From: Jeff Mahoney <jeffm@suse.com>
To: Jonathan Cameron <Jonathan.Cameron@gmail.com>
Cc: Greg KH <gregkh@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: Complete sched.h removal from interrupt.h
Date: Tue, 13 Oct 2009 10:24:11 -0400 [thread overview]
Message-ID: <4AD48D8B.10609@suse.com> (raw)
In-Reply-To: <4AD45F94.8060806@gmail.com>
On 10/13/2009 07:08 AM, Jonathan Cameron wrote:
> Hi Jeff,
>> drivers/staging/iio/industrialio-core.c | 2 ++
>>
> ...
>> --- a/drivers/staging/iio/industrialio-core.c
>> +++ b/drivers/staging/iio/industrialio-core.c
>> @@ -19,6 +19,8 @@
>> #include <linux/interrupt.h>
>> #include <linux/poll.h>
>> #include <linux/cdev.h>
>> +#include <linux/sched.h>
>> +#include <linux/wait.h>
>> #include "iio.h"
>> #include "trigger_consumer.h"
>>
> Greg has already picked up a patch for this one, but might make more
> sense to drop
> that and merge all these fixes as one. Original patch only added
> sched.h though.
> Is wait.h due to a similar issue that is going to bite in the future?
> (could chase this
> down but as you added it seemed easier to ask!)
Nope, I think iio was probably the first driver I saw this build failure
in and observed that it was in the wait queue code. It's not necessary,
though it doesn't cost anything either since wait.h is already included
somewhere.
-Jeff
--
Jeff Mahoney
SUSE Labs
prev parent reply other threads:[~2009-10-13 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 21:10 [PATCH] staging: Complete sched.h removal from interrupt.h Jeff Mahoney
2009-10-13 11:08 ` Jonathan Cameron
2009-10-13 14:24 ` Jeff Mahoney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD48D8B.10609@suse.com \
--to=jeffm@suse.com \
--cc=Jonathan.Cameron@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox