Re: [GIT PULL] kbuild fixes

[Michael Tokarev <mjt@tls.msk.ru>]

Sam Ravnborg wrote:
> On Mon, Oct 12, 2009 at 12:41:42PM +0400, Michael Tokarev wrote:
>> Sam Ravnborg wrote:
>>> Hi Linus.
>>>
>>> A few kbuild related fixes.
>> []
>>> - Fix use of echo -ne. Is caused issues for ubuntu (IIRC) users
>> As has been discussed previously (and Sam has been CC'ed), the fix
>> is still incorrect.
> 
> In the thread hpa asked for a patch at least twice.
> Only after I submitted -fixes to Linus it shows up.
> 
> Bad timing.
> 
> And please - do not even think of asking me to do it.

How many patches should one send? How many trees one should
compare against and send different patch for, in case such
an obvious trivial cases?  If I'll provide this against
mainline, it wont apply to Sam's tree.  If against Sam's
tree, it wont apply to mainline.  And for such trivial
cases, it's just amusing to expect full patch.

It's not bad timing.  I needed to know which damn tree
I should diff against.  In Sam's pull request I found
the - hopefully - correct tree.

Please don't even think I will be submitting something like
this again.  I spent half a week debugging a mysterious issue,
and I provided at least information in hope it will be useful
to someone with the same issue.  And it turns out that by doing
so, *I* owe something to everyone else.  It's not how things
works, or SHOULD work.

Thanks.

/mjt

> You guys are the one that see the issue, who know how to fix it,
> and knows how to check that the fix really works.
> 
> In other words - provide a patch next time you are asked to do so.
> 
> I'm off for much needed vacation rest of the week and
> may rememeber to handle the patch when I get back...
> 
> 	Sam