Re: [patch 4/6] brlock: introduce special brlocks

Andrew Morton
2009-10-19T05:27:39Z

On Thu, 15 Oct 2009 15:40:30 +1100 npiggin@suse.de wrote:

> +#define DECLARE_BRLOCK(name) \

This:

> + DECLARE_PER_CPU(spinlock_t, name##_lock); \
> + static inline void name##_lock_init(void) { \
> + int i; \
> + for_each_possible_cpu(i) { \
> + spinlock_t *lock; \
> + lock = &per_cpu(name##_lock, i); \
> + spin_lock_init(lock); \
> + } \
> + } \
> + static inline void name##_rlock(void) { \
> + spinlock_t *lock; \
> + lock = &get_cpu_var(name##_lock); \
> + spin_lock(lock); \
> + } \

generates a definition, not a declaration. Hence DEFINE_BRLOCK.

</petpeeve #29>