From: "H. Peter Anvin" <hpa@zytor.com>
To: Roland McGrath <roland@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, Sam Ravnborg <sam@ravnborg.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ian Lance Taylor <iant@google.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] x86: linker script syntax nits
Date: Thu, 15 Oct 2009 11:30:50 -0700 [thread overview]
Message-ID: <4AD76A5A.4050806@zytor.com> (raw)
In-Reply-To: <20091015182616.DFD875E6@magilla.sf.frob.com>
On 10/15/2009 11:26 AM, Roland McGrath wrote:
>> The other -- and somewhat less cantankerous way -- is to use a dummy symbol:
>>
>> #define LINUX_ASSERT(expr, name, string) name = ASSERT(expr, string)
>>
>> "name" would have to be unique for each instance.
>
> I wouldn't like to pollute the symtabs with those useless symbols.
>
> #define LINUX_ASSERT(expr, string) PROVIDE(_assert_bogon = ASSERT(expr, string))
>
> works with a recent ld. I don't know what the problematic old ld versions
> were. Do you have such on hand to test?
>
> Ian may have another suggestion.
>
I don't remember how old they have to be... I think RHEL 4 timeframe,
though.
-hpa
next prev parent reply other threads:[~2009-10-15 18:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 22:10 [PATCH] x86: linker script syntax nits Roland McGrath
2009-10-14 22:35 ` H. Peter Anvin
2009-10-15 6:13 ` [tip:x86/urgent] Revert "x86: linker script syntax nits" tip-bot for Ingo Molnar
2009-10-16 5:28 ` [tip:x86/urgent] x86: Document linker script ASSERT() quirk tip-bot for Ingo Molnar
2009-10-15 3:30 ` [PATCH] x86: linker script syntax nits Sam Ravnborg
2009-10-15 6:38 ` Ingo Molnar
2009-10-15 17:17 ` H. Peter Anvin
2009-10-15 18:26 ` Roland McGrath
2009-10-15 18:30 ` H. Peter Anvin [this message]
2009-10-15 19:27 ` Sam Ravnborg
2009-10-15 6:18 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD76A5A.4050806@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=iant@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox