public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joerg Abraham <Joerg.Abraham@alcatel-lucent.de>
To: John Kacur <jkacur@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>
Subject: Re: 2.6.31.4-rt14 posix message queues problem (solved)
Date: Fri, 16 Oct 2009 10:09:46 +0200	[thread overview]
Message-ID: <4AD82A4A.9060006@alcatel-lucent.de> (raw)
In-Reply-To: <alpine.LFD.2.00.0910152105430.8932@localhost.localdomain>

Hi John,

> Hello Joerg
> 
> Does the following patch solve your problem? 

yes, (verified on powerpc and x86_64)

so it may be save to include your patch into the next rt release.

Thanx,

Joerg


> 
> From 69fde4357db4a054733cbca4158606160e821a3a Mon Sep 17 00:00:00 2001
> From: John Kacur <jkacur@redhat.com>
> Date: Thu, 15 Oct 2009 20:52:37 +0200
> Subject: [PATCH] preempt_disable_rt(); should be paired with preempt_enable_rt()
> 
> Signed-off-by: John Kacur <jkacur@redhat.com>
> ---
>  ipc/mqueue.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/ipc/mqueue.c b/ipc/mqueue.c
> index 63a47f7..ab4df36 100644
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -830,7 +830,7 @@ static inline void pipelined_send(struct mqueue_inode_info *info,
>  	wake_up_process(receiver->task);
>  	smp_wmb();
>  	receiver->state = STATE_READY;
> -	preempt_enable_nort();
> +	preempt_enable_rt();
>  }
>  
>  /* pipelined_receive() - if there is task waiting in sys_mq_timedsend()


      parent reply	other threads:[~2009-10-16  8:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-15 17:51 2.6.31.4-rt14 posix message queues problem Joerg Abraham
     [not found] ` <520f0cf10910151202k2ba01453r10e96eeb064232e8@mail.gmail.com>
2009-10-15 19:09   ` John Kacur
2009-10-15 20:19     ` John Kacur
2009-10-16  8:09     ` Joerg Abraham [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD82A4A.9060006@alcatel-lucent.de \
    --to=joerg.abraham@alcatel-lucent.de \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox