From: Stas Sergeev <stsp@aknet.ru>
To: Greg KH <gregkh@suse.de>
Cc: Linux kernel <linux-kernel@vger.kernel.org>
Subject: [patch] fix driver_register() return value
Date: Sun, 18 Oct 2009 00:31:38 +0400 [thread overview]
Message-ID: <4ADA29AA.9070907@aknet.ru> (raw)
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
Hi Greg.
In this patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=16dc42e018c2868211b4928f20a957c0c216126c
the check was added for another
driver to already claim the same
device on the same bus. But the
returned error code was wrong:
to modprobe, the -EEXIST means
that _this_ driver is already
installed. It therefore doesn't
produce the needed error message
when _another_ driver is trying
to register for the same device.
Returning -EBUSY fixes the problem.
Signed-off-by: Stas Sergeev <stsp@aknet.ru>
[-- Attachment #2: drv_busy.diff --]
[-- Type: text/x-patch, Size: 403 bytes --]
diff --git a/drivers/base/driver.c b/drivers/base/driver.c
index ed2ebd3..f367885 100644
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
@@ -236,7 +236,7 @@ int driver_register(struct device_driver *drv)
put_driver(other);
printk(KERN_ERR "Error: Driver '%s' is already registered, "
"aborting...\n", drv->name);
- return -EEXIST;
+ return -EBUSY;
}
ret = bus_add_driver(drv);
next reply other threads:[~2009-10-17 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-17 20:31 Stas Sergeev [this message]
2009-10-17 20:46 ` [patch] fix driver_register() return value Greg KH
2009-10-17 21:03 ` Stas Sergeev
2009-10-26 23:56 ` patch driver-core-fix-driver_register-return-value.patch added to gregkh-2.6 tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADA29AA.9070907@aknet.ru \
--to=stsp@aknet.ru \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox