From: Stas Sergeev <stsp@aknet.ru>
To: Greg KH <gregkh@suse.de>
Cc: Linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] fix driver_register() return value
Date: Sun, 18 Oct 2009 01:03:50 +0400 [thread overview]
Message-ID: <4ADA3136.1090802@aknet.ru> (raw)
In-Reply-To: <20091017204608.GA5676@suse.de>
18.10.2009 00:46, Greg KH wrote:
>> Returning -EBUSY fixes the problem.
>> Signed-off-by: Stas Sergeev<stsp@aknet.ru>
> Does this cause problems with the way things now are? If so, what are
> they?
They are simple.
Suppose the pcspkr driver was loaded
by the udev. Then someone types:
modprobe snd-pcsp
and that doesn't print anything, so
he thinks the snd-pcsp was loaded and
asks me why there is no sound. :)
Only by typing "dmesg" you can see what
actually happened, but it would be better
to have that from modprobe too.
> Does this change need to be backported to older -stable kernels?
I think it can't hurt.
next prev parent reply other threads:[~2009-10-17 20:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-17 20:31 [patch] fix driver_register() return value Stas Sergeev
2009-10-17 20:46 ` Greg KH
2009-10-17 21:03 ` Stas Sergeev [this message]
2009-10-26 23:56 ` patch driver-core-fix-driver_register-return-value.patch added to gregkh-2.6 tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADA3136.1090802@aknet.ru \
--to=stsp@aknet.ru \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox