[patch][rfc] depend pcspkr on CONFIG_EMBEDDED

Stas Sergeev
2009-10-17T21:17:27Z

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

Hello.

As most of the problems with snd-pcsp
are now settled and the major distros
are starting to unblacklist it and use
instead of pcspkr:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=539767
I'd like to do that sneaky thing.
The major argument for keeping pcspkr
I've heard, was that it doesn't require
the entire ALSA stack, and in this
case I think it is usefull only with
CONFIG_EMBEDDED. Right now it is a common
situation when the both modules are
built, and whichever gets loaded first,
works.
So can something like the attached
patch be applied?

---
Depend pcspkr on CONFIG_EMBEDDED to reduce
the chances of both the pcspkr and snd-pcsp
being built together. pcspkr is good only
by not requiring ALSA; apart from that,
snd-pcsp does everything.

Signed-off-by: Stas Sergeev <stsp@aknet.ru>

[-- Attachment #2: pcspkr_dep.diff --]
[-- Type: text/x-patch, Size: 711 bytes --]

diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 02f4f8f..3571569 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -14,10 +14,14 @@ if INPUT_MISC

config INPUT_PCSPKR
tristate "PC Speaker support"
- depends on PCSPKR_PLATFORM
+ depends on PCSPKR_PLATFORM && EMBEDDED
help
Say Y here if you want the standard PC Speaker to be used for
- bells and whistles.
+ bells and whistles. This driver is small and is good when you
+ do not need any other sounds from your machine.
+ There is another driver that does the same and also has the
+ PCM capabilities, called snd-pcsp, but it requires the entire
+ ALSA stack.

If unsure, say Y.