From: Tejun Heo <tj@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jeff Mahoney <jeffm@suse.com>, Jiri Kosina <jkosina@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: Commit 34d76c41 causes linker errors on ia64 with NR_CPUS=4096
Date: Tue, 20 Oct 2009 22:58:20 +0900 [thread overview]
Message-ID: <4ADDC1FC.8010903@kernel.org> (raw)
In-Reply-To: <4ADDC1C6.9090305@kernel.org>
Of course I forgot to actually cc. Cc'ing and quoting whole body.
Sorry.
Tejun Heo wrote:
> Ingo Molnar wrote:
>> IA64 should be fixed really - we can get past the 64K of percpu data
>> limit anytime we add a few more pages of per-cpu data to the kernel -
>> the scheduler just happened to be the one to cross it this time.
>
> Christoph (cc'd hi!) was talking about re-purposing one of reserved
> generic registers (for current or something, I don't remember the
> details) for percpu base and just getting the original one via percpu
> access. With that we should be able to lift the limitation without
> much performance penalty.
>
>> Saying that all static percpu data must be below 64K, which will only be
>> noticed once IA64 gets its testing act together months after it's been
>> created is silly. If you want to enforce such a limit make it testable
>> in a _timely_ fashion. Or fix the limit really.
>
> Yeah, the problem probably was that it only pushes the perpcu area
> very slightly over the limit depending on configuration so it's not
> too surprising that it didn't get reported for some time. Also, the
> linker script thing is a sanity check which is intentionally put there
> to trigger when this happens so that it can be found out clearly
> during build time.
>
> In the long term, it will be a good idea to lift that restriction.
> That said, I really don't think we should be adding NR_CPUS sized
> array to percpu area either. Things like that quickly become very
> scary with N*1024 cpu configurations.
--
tejun
next prev parent reply other threads:[~2009-10-20 13:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 22:28 Commit 34d76c41 causes linker errors on ia64 with NR_CPUS=4096 Jeff Mahoney
2009-10-20 2:02 ` Jiri Kosina
2009-10-20 4:57 ` Jiri Kosina
2009-10-20 5:21 ` Tejun Heo
2009-10-20 5:58 ` Jiri Kosina
2009-10-20 6:12 ` Tejun Heo
2009-10-20 6:14 ` Tejun Heo
2009-10-20 6:27 ` Jiri Kosina
2009-10-20 14:18 ` Jeff Mahoney
2009-10-20 14:49 ` Jeff Mahoney
2009-10-21 6:11 ` Ingo Molnar
2009-10-21 15:19 ` Tejun Heo
2009-10-21 22:11 ` Luck, Tony
2009-10-22 14:49 ` Jiri Kosina
2009-10-22 14:53 ` Jeff Mahoney
2009-10-22 22:24 ` Luck, Tony
2009-10-23 7:51 ` Ingo Molnar
2009-10-23 12:30 ` Jiri Kosina
2009-10-26 16:38 ` Jiri Kosina
2009-10-26 20:16 ` Ingo Molnar
2009-10-27 10:03 ` Jiri Kosina
2009-10-27 10:52 ` Jiri Kosina
2009-10-20 6:15 ` Ingo Molnar
2009-10-20 6:26 ` Jiri Kosina
2009-10-20 6:35 ` Ingo Molnar
2009-10-20 7:11 ` Eric Dumazet
2009-10-20 7:39 ` Tejun Heo
2009-10-20 7:12 ` Tejun Heo
2009-10-20 7:17 ` Jiri Kosina
2009-10-20 7:36 ` Tejun Heo
2009-10-20 13:08 ` Jeff Mahoney
2009-10-20 13:43 ` Ingo Molnar
2009-10-20 13:57 ` Tejun Heo
2009-10-20 13:58 ` Tejun Heo [this message]
2009-10-21 6:43 ` Christoph Lameter
2009-10-20 9:21 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADDC1FC.8010903@kernel.org \
--to=tj@kernel.org \
--cc=cl@linux-foundation.org \
--cc=fenghua.yu@intel.com \
--cc=jeffm@suse.com \
--cc=jkosina@suse.cz \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox