public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] frv: Fix check on unsigned in do_signal()
@ 2009-10-20 18:04 Roel Kluin
  0 siblings, 0 replies; 2+ messages in thread
From: Roel Kluin @ 2009-10-20 18:04 UTC (permalink / raw)
  To: David Howells, Andrew Morton, LKML

syscallno is unsigned

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Was this maybe intended?

diff --git a/arch/frv/kernel/signal.c b/arch/frv/kernel/signal.c
index 6b0a2b6..0974c0e 100644
--- a/arch/frv/kernel/signal.c
+++ b/arch/frv/kernel/signal.c
@@ -527,7 +527,7 @@ static void do_signal(void)
 
 no_signal:
 	/* Did we come from a system call? */
-	if (__frame->syscallno >= 0) {
+	if (__frame->syscallno != -1) {
 		/* Restart the system call - no handlers present */
 		switch (__frame->gr8) {
 		case -ERESTARTNOHAND:

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* [PATCH] frv: Fix check on unsigned in do_signal()
@ 2009-10-26 15:49 David Howells
  0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2009-10-26 15:49 UTC (permalink / raw)
  To: torvalds, akpm; +Cc: linux-kernel, Roel Kluin, David Howells

From: Roel Kluin <roel.kluin@gmail.com>

syscallno is unsigned

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---

 arch/frv/kernel/signal.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/arch/frv/kernel/signal.c b/arch/frv/kernel/signal.c
index 6b0a2b6..0974c0e 100644
--- a/arch/frv/kernel/signal.c
+++ b/arch/frv/kernel/signal.c
@@ -527,7 +527,7 @@ static void do_signal(void)
 
 no_signal:
 	/* Did we come from a system call? */
-	if (__frame->syscallno >= 0) {
+	if (__frame->syscallno != -1) {
 		/* Restart the system call - no handlers present */
 		switch (__frame->gr8) {
 		case -ERESTARTNOHAND:


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-10-26 15:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-20 18:04 [PATCH] frv: Fix check on unsigned in do_signal() Roel Kluin
  -- strict thread matches above, loose matches on Subject: below --
2009-10-26 15:49 David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox