Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic

[David Daney <ddaney@caviumnetworks.com>]

Thomas Gleixner wrote:
> On Sun, 18 Oct 2009, Linus Walleij wrote:
>> This moves the clocksource_set_clock() and clockevent_set_clock()
>> from the MIPS timer code into clockchips and clocksource where
>> it belongs. The patch was triggered by code posted by Mikael
>> Pettersson duplicating this code for the IOP ARM system. The
>> function signatures where altered slightly to fit into their
>> destination header files, unsigned int changed to u32 and inlined.
>>
>> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Mikael Pettersson <mikpe@it.uu.se>
>> Cc: Ralf Baechle <ralf@linux-mips.org>
>> ---
>> Ralf has stated in earlier conversation that this should be moved,
>> now we risk duplicating code so let's move it.
> 
> Please do not make that functions inline. They are too large and there
> is no benefit of inlining them.
> 

If that is the case, then perhaps they should not be defined in a header 
file.

IMHO if you are defining a function in a header file it should always be 
  'static inline'.  If you don't want it in-lined, put it in some 
library so we only pick up a single instance of it.

David Daney