From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Daniel Walker <dwalker@fifo99.com>,
Erwan Velu <erwanaliasr1@gmail.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] dmi_check_system can generate Warnings when no DMI table is present
Date: Fri, 23 Oct 2009 10:31:14 -0700 [thread overview]
Message-ID: <4AE1E862.8090109@goop.org> (raw)
In-Reply-To: <20091023170428.GA25484@elte.hu>
On 10/23/09 10:04, Ingo Molnar wrote:
>> Yes. There's nothing preventing the DMI subsystem from being
>> initialized under Xen; in fact we rely on it in a dom0 kernel (which
>> does have access to the DMI tables). I don't know what the underlying
>> bug in the original report is, but there's more to it than failing to
>> init DMI.
>>
> yeah. It's probably some init ordering problem - some version of Xen
> calling into the DMI code too early. It probably doesnt even matter in
> practice as we rarely rely on DMI details in Xen guests, right?
>
The backtraces in the original report showed that the messages were
coming from DMI calls in the PCI init path or i8042_init. PCI shouldn't
be being called early, and i8042_init is just a normal module_init.
DomU has no DMI (we just put all zeros into the ISA window to catch any
probes), and nothing Xen-specific has any DMI dependencies. So there
should be no cause to make any premature dmi calls.
It looks like setup_arch() is being missed, but its hard to see how we'd
get very far in that case...
Also, the referenced reports are for distro kernels which may not
contain mainline Xen in the first place (Novell have their own massive
Xen patch stack they dump onto the kernels before shipping, so Xen bug
reports against SuSE kernels don't have any relevance to mainline). I'd
like to see a boot log of a mainline kernel showing the problem.
J
next prev parent reply other threads:[~2009-10-23 17:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 9:34 [PATCH] dmi_check_system can generate Warnings when no DMI table is present Erwan Velu
2009-10-23 10:08 ` Daniel Walker
2009-10-23 10:34 ` Erwan Velu
2009-10-23 10:42 ` Daniel Walker
2009-10-23 10:46 ` Erwan Velu
2009-10-23 11:00 ` Ingo Molnar
2009-10-23 11:03 ` Ingo Molnar
2009-10-23 11:49 ` Erwan Velu
2009-10-23 12:47 ` Daniel Walker
2009-10-23 15:03 ` Erwan Velu
2009-10-23 15:09 ` Daniel Walker
2009-10-23 15:30 ` Ingo Molnar
2009-10-23 17:00 ` Jeremy Fitzhardinge
2009-10-23 17:04 ` Ingo Molnar
2009-10-23 17:31 ` Jeremy Fitzhardinge [this message]
2009-10-23 16:57 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE1E862.8090109@goop.org \
--to=jeremy@goop.org \
--cc=dwalker@fifo99.com \
--cc=erwanaliasr1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox