Re: [Resend] [PATCH] ACPI: New driver for Lenovo SL laptops

Bjorn Helgaas
2009-10-23T21:43:18Z

On Friday 23 October 2009 01:11:48 pm Ike Panhc wrote:

> +static int __init lenovo_sl_laptop_init(void)
> +{
> + int ret;
> + acpi_status status;
> +
> + if (acpi_disabled)
> + return -ENODEV;

Don't need this.

> + lenovo_sl_laptop_hkey_handle = lenovo_sl_laptop_ec0_handle = NULL;
> + status = acpi_get_handle(NULL, ACPI_HKEY_PATH,
> + &lenovo_sl_laptop_hkey_handle);
> + if (ACPI_FAILURE(status)) {
> + pr_err("Failed to get ACPI handle for %s\n", ACPI_HKEY_PATH);
> + return -ENODEV;
> + }

Don't need this; acpi_bus_register_driver() is enough.

Bjorn