Re: [Resend] [PATCH] ACPI: New driver for Lenovo SL laptops

Alexey Starikovskiy
2009-10-23T20:57:09Z

Hi Ike,

I'm sorry to say this, bit it looks like your design is seriously
flowed. Not any ACPI device should
require interception of EC query events.

You should register device for HID "ATK0101" and get all notifications
there, as it is done for
for ASUS ATK0100 hot key driver (drivers/platform/x86/asus-laptop.c),
and I would guess,
that driver for ASUS ATK0101 hot key driver may be either an extension
to ATK0100 driver
or based on it, if new device does not share any events.
This would be real solution, and not a hack for a single notebook/BIOS
version.
From the DSDT it is obvious that _Q numbers are not permanent and could
change even
with the next BIOS revision.

You may also contact current maintainer of asus-laptop driver, Corentin
Chary, as he might help you with design.

Regards,
Alex.

Ike Panhc пишет:
> Hi Alex,
>
> The attachment is the acpidump.
>
> I register for EC query events because it is an event source of hotkey
> press
>
> Alexey Starikovskiy wrote:
>
>> Hi,
>>
>> Could you please post acpidump from this machine, I would like to
>> understand,
>> why you need to register for EC query events.
>>
>> Thanks,
>> Alex.
>>
>>
>
>