From: Alexey Starikovskiy <aystarik@gmail.com>
To: Ike Panhc <ike.pan@canonical.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Rostovtsev <tetromino@gmail.com>,
Corentin CHARY <corentincj@iksaif.net>
Subject: Re: [Resend] [PATCH] ACPI: New driver for Lenovo SL laptops
Date: Sat, 24 Oct 2009 00:57:09 +0400 [thread overview]
Message-ID: <4AE218A5.5070008@gmail.com> (raw)
In-Reply-To: <4AE20AA2.2090201@canonical.com>
Hi Ike,
I'm sorry to say this, bit it looks like your design is seriously
flowed. Not any ACPI device should
require interception of EC query events.
You should register device for HID "ATK0101" and get all notifications
there, as it is done for
for ASUS ATK0100 hot key driver (drivers/platform/x86/asus-laptop.c),
and I would guess,
that driver for ASUS ATK0101 hot key driver may be either an extension
to ATK0100 driver
or based on it, if new device does not share any events.
This would be real solution, and not a hack for a single notebook/BIOS
version.
From the DSDT it is obvious that _Q numbers are not permanent and could
change even
with the next BIOS revision.
You may also contact current maintainer of asus-laptop driver, Corentin
Chary, as he might help you with design.
Regards,
Alex.
Ike Panhc пишет:
> Hi Alex,
>
> The attachment is the acpidump.
>
> I register for EC query events because it is an event source of hotkey
> press
>
> Alexey Starikovskiy wrote:
>
>> Hi,
>>
>> Could you please post acpidump from this machine, I would like to
>> understand,
>> why you need to register for EC query events.
>>
>> Thanks,
>> Alex.
>>
>>
>
>
next prev parent reply other threads:[~2009-10-23 20:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 15:12 [PATCH] ACPI: New driver for Lenovo SL laptops Ike Panhc
2009-09-25 4:34 ` Dmitry Torokhov
2009-09-25 16:20 ` Alan Jenkins
2009-09-25 16:54 ` Alan Jenkins
2009-10-23 19:11 ` [Resend] " Ike Panhc
2009-10-23 19:18 ` Ike Panhc
2009-10-23 19:34 ` Alexey Starikovskiy
2009-10-23 19:57 ` Ike Panhc
2009-10-23 20:57 ` Alexey Starikovskiy [this message]
2009-10-23 21:43 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE218A5.5070008@gmail.com \
--to=aystarik@gmail.com \
--cc=corentincj@iksaif.net \
--cc=ike.pan@canonical.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tetromino@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox