From: Jiri Slaby <jirislaby@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
x86@kernel.org, linux-kernel@vger.kernel.org,
Vivek Goyal <vgoyal@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Simon Horman <horms@verge.net.au>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH 1/1] crash_dump: fix non-pae kdump kernel memory accesses
Date: Mon, 26 Oct 2009 11:12:30 +0100 [thread overview]
Message-ID: <4AE5760E.5080401@gmail.com> (raw)
In-Reply-To: <20091025162018.GB20391@elte.hu>
On 10/25/2009 05:20 PM, Ingo Molnar wrote:
>> +#ifndef CONFIG_X86_PAE
>> +/* non-PAE kdump kernel executed from a PAE one will crop high pte bits and
>> + poke unwanted space counting again from address 0, we don't want that */
>> +static inline bool is_crashed_pfn_valid(unsigned long pfn)
>> +{
>> + /* on non-PAE pte must fit into unsigned long
>> + in fact the test is (pfn & 0x000fffff) */
>> + return pte_pfn(pfn_pte(pfn, __pgprot(0))) == pfn;
>> +}
>> +#else
>> +static inline bool is_crashed_pfn_valid(unsigned long pfn) { return true; }
>> +#endif
>
> i'd suggest to push the #ifdef inside the function.
I posted a v2 patch a second ago. Thanks.
prev parent reply other threads:[~2009-10-26 10:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 15:45 [PATCH 1/1] crash_dump: fix non-pae kdump kernel memory accesses Jiri Slaby
2009-10-25 16:20 ` Ingo Molnar
2009-10-26 10:11 ` [PATCH v2 " Jiri Slaby
2009-10-26 15:24 ` [tip:x86/urgent] x86: crash_dump: Fix " tip-bot for Jiri Slaby
2009-10-26 20:40 ` [PATCH v2 1/1] crash_dump: fix " Eric W. Biederman
2009-10-27 13:17 ` Vivek Goyal
2009-10-26 10:12 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE5760E.5080401@gmail.com \
--to=jirislaby@gmail.com \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox