public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: the arch/x86 maintainers <x86@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>,
	athena@fftw.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: fix iommu=nodac parameter handling
Date: Mon, 26 Oct 2009 15:41:46 +0100	[thread overview]
Message-ID: <4AE5B52A.4050408@kernel.org> (raw)

nodac should forbid dac instead of enabling it.  Fix it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Matteo Frigo <athena@fftw.org>
Cc: stable@kernel.org
---
This was posted several months ago in a two patch series.  The second
one was rejected by Alan and with that the first one got lost too
although it's an apparent bug fix.  Matteo hit this bug recently and
reminded me about this patch.  So, regenerated and reposting.

Thanks.

 arch/x86/kernel/pci-dma.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index d20009b..8cf3996 100644
--- a/arch/x86/kernel/pci-dma.c
+++ b/arch/x86/kernel/pci-dma.c
@@ -216,7 +216,7 @@ static __init int iommu_setup(char *p)
 		if (!strncmp(p, "allowdac", 8))
 			forbid_dac = 0;
 		if (!strncmp(p, "nodac", 5))
-			forbid_dac = -1;
+			forbid_dac = 1;
 		if (!strncmp(p, "usedac", 6)) {
 			forbid_dac = -1;
 			return 1;

             reply	other threads:[~2009-10-26 14:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-26 14:41 Tejun Heo [this message]
2009-11-04 12:28 ` [PATCH] x86: fix iommu=nodac parameter handling Ingo Molnar
2009-11-05  4:44   ` FUJITA Tomonori
2009-11-08 13:07 ` [tip:core/iommu] x86: Fix " tip-bot for Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE5B52A.4050408@kernel.org \
    --to=tj@kernel.org \
    --cc=athena@fftw.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox