From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754673AbZJ0MzO (ORCPT ); Tue, 27 Oct 2009 08:55:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754261AbZJ0MzI (ORCPT ); Tue, 27 Oct 2009 08:55:08 -0400 Received: from hera.kernel.org ([140.211.167.34]:58734 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754344AbZJ0Myi (ORCPT ); Tue, 27 Oct 2009 08:54:38 -0400 Message-ID: <4AE6EDBF.7040905@kernel.org> Date: Tue, 27 Oct 2009 13:55:27 +0100 From: Tejun Heo User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Jiri Kosina CC: Ingo Molnar , Peter Zijlstra , Jeff Mahoney , Linux Kernel Mailing List , Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org Subject: Re: [PATCH 1/2] percpu: allow pcpu_alloc() to be called with IRQs off References: In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiri Kosina wrote: > pcpu_alloc() and pcpu_extend_area_map() perform a series of > spin_lock_irq()/spin_unlock_irq() calls, which make them unsafe > with respect to being called from contexts which have IRQs off. > > This patch converts the code to perform save/restore of flags instead, > making pcpu_alloc() (or __alloc_percpu() respectively) to be called > from early kernel startup stage, where IRQs are off. > > This is needed for proper initialization of per-cpu rq_weight data from > sched_init(). > > Signed-off-by: Jiri Kosina Acked-by: Tejun Heo I'll wait for response on the series and push it through percpu#fixes tomorrow if there's no objection. Thanks. -- tejun