* [PATCH] tracing: Fix to use unused attribute
@ 2009-10-28 1:44 Li Zefan
2009-10-29 7:57 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Li Zefan @ 2009-10-28 1:44 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Steven Rostedt, Frederic Weisbecker, LKML
____ftrace_check_##name() is used for compile-time check
on F_printk() only, so it should be marked as __unused
instead of __used.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
I'm thinking about introducing __always_unused, comparing
to __maybe_unused.
---
kernel/trace/trace_export.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace_export.c b/kernel/trace/trace_export.c
index 934d81f..85309fc 100644
--- a/kernel/trace/trace_export.c
+++ b/kernel/trace/trace_export.c
@@ -48,11 +48,12 @@
struct ____ftrace_##name { \
tstruct \
}; \
-static void __used ____ftrace_check_##name(void) \
+static void __attribute__((unused)) \
+____ftrace_check_##name(void) \
{ \
struct ____ftrace_##name *__entry = NULL; \
\
- /* force cmpile-time check on F_printk() */ \
+ /* force compile-time check on F_printk() */ \
printk(print); \
}
--
1.6.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tracing: Fix to use unused attribute
2009-10-28 1:44 [PATCH] tracing: Fix to use unused attribute Li Zefan
@ 2009-10-29 7:57 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2009-10-29 7:57 UTC (permalink / raw)
To: Li Zefan, Linus Torvalds, Andrew Morton
Cc: Steven Rostedt, Frederic Weisbecker, LKML
* Li Zefan <lizf@cn.fujitsu.com> wrote:
> ____ftrace_check_##name() is used for compile-time check
> on F_printk() only, so it should be marked as __unused
> instead of __used.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
>
> I'm thinking about introducing __always_unused, comparing
> to __maybe_unused.
>
> ---
> kernel/trace/trace_export.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace_export.c b/kernel/trace/trace_export.c
> index 934d81f..85309fc 100644
> --- a/kernel/trace/trace_export.c
> +++ b/kernel/trace/trace_export.c
> @@ -48,11 +48,12 @@
> struct ____ftrace_##name { \
> tstruct \
> }; \
> -static void __used ____ftrace_check_##name(void) \
> +static void __attribute__((unused)) \
> +____ftrace_check_##name(void) \
> { \
> struct ____ftrace_##name *__entry = NULL; \
> \
> - /* force cmpile-time check on F_printk() */ \
> + /* force compile-time check on F_printk() */ \
> printk(print); \
> }
Hm, open-coding __attribute__()'s is not good.
These tags are somewhat of a mess:
#if __GNUC_MINOR__ >= 3
# define __used __attribute__((__used__))
#else
# define __used __attribute__((__unused__))
#endif
I've Cc:-ed Linus and Andrew, to solicite feedback on __always_unused. I
think we should add it.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-29 7:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-28 1:44 [PATCH] tracing: Fix to use unused attribute Li Zefan
2009-10-29 7:57 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox