From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755239AbZJ2Pgk (ORCPT ); Thu, 29 Oct 2009 11:36:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754905AbZJ2Pgj (ORCPT ); Thu, 29 Oct 2009 11:36:39 -0400 Received: from claw.goop.org ([74.207.240.146]:50069 "EHLO claw.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752777AbZJ2Pgj (ORCPT ); Thu, 29 Oct 2009 11:36:39 -0400 Message-ID: <4AE7A816.3050607@goop.org> Date: Tue, 27 Oct 2009 19:10:30 -0700 From: Jeremy Fitzhardinge User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4 MIME-Version: 1.0 To: Christian Kujau CC: LKML , x86@kernel.org, torvalds@linux-foundation.org, Thomas Gleixner Subject: Re: 2.6.32-rc not booting with Xen-3.2 (bisected) References: <4AE628DB.5010305@goop.org> <4AE67506.2040200@goop.org> <4AE73973.3070709@goop.org> In-Reply-To: X-Enigmail-Version: 0.97a Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/09 12:01, Christian Kujau wrote: > On Tue, 27 Oct 2009 at 11:18, Jeremy Fitzhardinge wrote: > >> $ gdb vmlinux >> (gdb) x/i 0xffffffff812c50ad >> > The value is always ffffffff812c50ad, gdb says: > > (gdb) x/i 0xffffffff812c50ad > 0xffffffff812c50ad : ud2a > Please try the patch below. >> Hm, sounds like a xenstored bug, or something is just pounding on it. >> Are there any other domains running, or other busy processes? >> > Yes, there's another domU running. But the high load and xenstored > spinning is only happening when I try to start the domain with this > 2.6.32-rc kernel. > That seems unlikely to be related (or a secondary effect of having a domain crash). J Subject: [PATCH] xen: set up mmu_ops before trying to set any ptes xen_setup_stackprotector() ends up trying to set page protections, so we need to have vm_mmu_ops set up before trying to do so. Failing to do so causes an early boot crash. [ Impact: Fix early crash under Xen. ] Signed-off-by: Jeremy Fitzhardinge diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 3439616..23a4d80 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -1075,6 +1075,8 @@ asmlinkage void __init xen_start_kernel(void) * Set up some pagetable state before starting to set any ptes. */ + xen_init_mmu_ops(); + /* Prevent unwanted bits from being set in PTEs. */ __supported_pte_mask &= ~_PAGE_GLOBAL; if (!xen_initial_domain()) @@ -1099,7 +1101,6 @@ asmlinkage void __init xen_start_kernel(void) */ xen_setup_stackprotector(); - xen_init_mmu_ops(); xen_init_irq_ops(); xen_init_cpuid_mask();