public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Jes Sorensen <jes@sgi.com>,
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
	"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] ia64/sn: fix percpu warnings
Date: Wed, 28 Oct 2009 16:03:04 +0100	[thread overview]
Message-ID: <4AE85D28.90809@kernel.org> (raw)
In-Reply-To: <57C9024A16AD2D4C97DC78E552063EA3E345953E@orsmsx505.amr.corp.intel.com>

Hello,

Luck, Tony wrote:
>> WARNING: "per_cpu____sn_cnodeid_to_nasid" [drivers/misc/sgi-xp/xpc.ko] has no CRC!
> 
> Note that this warning goes away if I fix the mismatch declaration so
> that we have:
> 
> DECLARE_PER_CPU(short, __sn_cnodeide_to_nasid[MAX_COMPACT_NODES]);
> in arch.h
> 
> and
> 
> DEFINE_PER_CPU(short, __sn_cnodeide_to_nasid[MAX_COMPACT_NODES]);
> in setup.c

Umm... the correct correct declaration and definition would be

DECLARE_PER_CPU(short [MAX_COMPACT_NODES], __sn_cnodeide_to_nasid);

and

DEFINE_PER_CPU(short [MAX_COMPACT_NODES], __sn_cnodeide_to_nasid);

So that the first part contains full type.  Doing it the other way
might cause problems if the __weak trick is turned on.

Thanks.

-- 
tejun

  reply	other threads:[~2009-10-28 15:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-14  5:34 linux-next: Tree for October 14 Stephen Rothwell
2009-10-14 15:55 ` Randy Dunlap
2009-10-14 21:12   ` Stephen Rothwell
2009-10-14 22:10 ` [PATCH -next] ia64/sn: fix percpu warnings Randy Dunlap
2009-10-15  1:33   ` Tejun Heo
2009-10-26 18:24     ` Tony Luck
2009-10-26 23:35       ` Luck, Tony
2009-10-28 15:03         ` Tejun Heo [this message]
2009-10-28 16:24           ` Luck, Tony
2009-10-28 16:37             ` Tejun Heo
2009-10-28 16:58               ` Luck, Tony
2009-10-28 22:23                 ` Luck, Tony
2009-10-29 14:43                   ` Tejun Heo
2009-10-29 15:43                     ` Tejun Heo
2009-10-30 16:05                       ` Jan Beulich
2009-10-14 22:10 ` [PATCH -next] kvm: fix ia64 printk formats Randy Dunlap
2009-10-15  2:32   ` Zhang, Xiantao
2009-10-15  1:17 ` [PATCH -next] vmxnet: fix 2 build problems Randy Dunlap
2009-10-15  2:00   ` [Pv-drivers] " Bhavesh Davda
2009-10-15  3:39     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE85D28.90809@kernel.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=jes@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox