Re: [PATCH] Staging: Android logger: fix compiling error

Greg KH
2009-10-29T01:20:58Z

On Thu, Oct 29, 2009 at 09:11:39AM +0800, Bryan Wu wrote:
> Greg KH wrote:
> > On Thu, Oct 29, 2009 at 09:01:07AM +0800, Bryan Wu wrote:
> >> Greg KH wrote:
> >>> On Tue, Oct 27, 2009 at 12:40:07PM +0800, Eric Miao wrote:
> >>>>> Compiling broke since commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
> >>>>> headers: remove sched.h from poll.h
> >>>>>
> >>>>> Adding <linux/sched.h> to fix this compiling bug.
> >>> I have now just marked the android drivers as broken, as this is not the
> >>> only build error in them at the moment :(
> >>>
> >> Yeah, actually the drivers/staging/android/lowmemorykiller.c has been
> >> failing to compile for a long time, because that struct mm_struct does
> >> not have a field named oom_adj. All the Android drivers are compiled
> >> as modules in Ubuntu kernel package, except this one.
> >>
> >> Although Android public kernel is still in 2.6.29, it's own driver is
> >> totally different with our mainline staging version. Is there any plan
> >> to sync with it?
> >
> > No, Google has abandoned any current effort to push code upstream for
> > the past year :(
> >
> > The android drivers are deleted in linux-next and will go away in 2.6.33
> > because of this.
> >
>
> Thanks a lot for this update. It looks like we need to consider to drop Android
> modules in our Ubuntu kernel building somehow.

As no one is using them, it should be trivial to just change your kernel
config, right?

thanks,

greg k-h