Re: [PATCH] Staging: Android logger: fix compiling error

Greg KH
2009-10-29T01:31:49Z

On Thu, Oct 29, 2009 at 09:27:40AM +0800, Bryan Wu wrote:
> Greg KH wrote:
> > On Thu, Oct 29, 2009 at 09:11:39AM +0800, Bryan Wu wrote:
> >> Greg KH wrote:
> >>> On Thu, Oct 29, 2009 at 09:01:07AM +0800, Bryan Wu wrote:
> >>>> Greg KH wrote:
> >>>>> On Tue, Oct 27, 2009 at 12:40:07PM +0800, Eric Miao wrote:
> >>>>>>> Compiling broke since commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
> >>>>>>> headers: remove sched.h from poll.h
> >>>>>>>
> >>>>>>> Adding <linux/sched.h> to fix this compiling bug.
> >>>>> I have now just marked the android drivers as broken, as this is not the
> >>>>> only build error in them at the moment :(
> >>>>>
> >>>> Yeah, actually the drivers/staging/android/lowmemorykiller.c has been
> >>>> failing to compile for a long time, because that struct mm_struct does
> >>>> not have a field named oom_adj. All the Android drivers are compiled
> >>>> as modules in Ubuntu kernel package, except this one.
> >>>>
> >>>> Although Android public kernel is still in 2.6.29, it's own driver is
> >>>> totally different with our mainline staging version. Is there any plan
> >>>> to sync with it?
> >>> No, Google has abandoned any current effort to push code upstream for
> >>> the past year :(
> >>>
> >>> The android drivers are deleted in linux-next and will go away in 2.6.33
> >>> because of this.
> >>>
> >> Thanks a lot for this update. It looks like we need to consider to drop Android
> >> modules in our Ubuntu kernel building somehow.
> >
> > As no one is using them, it should be trivial to just change your kernel
> > config, right?
> >
>
> The reason we include them is that we wanna port the Android runtime environment
> to Ubuntu. Then the Android applications can run on Android compatible Ubuntu OS
> directly without any modification.
>
> The Android runtime environment needs some Android drivers such as Binder.

Don't you also need the wakelocks and the hooks in the core of the
kernel to tie into the binder mess?

> But now, it is hard for us to do that without a workable Android drivers in
> mainline.

Then push on Google to get them cleaned up and fixed! Or do it
yourself, all I need is a developer to take ownership of the code.

thanks,

greg k-h