public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86: sched: fix for non SMP systems in sched.h
@ 2009-10-30 14:34 Ralf Rösch
  2009-11-08 11:52 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Ralf Rösch @ 2009-10-30 14:34 UTC (permalink / raw)
  To: a.p.zijlstra; +Cc: linux-kernel, hpa, mingo, Thomas Gleixner, mingo

commit d65d153bc23b84e4709a49137a9a03ae139d51a0 introduced
two new prototypes: default_scale_freq_power and default_scale_smt_power.
Both of them use struct sched_domain which is not defined on non SMP 
systems.
Just moved the prototypes to the correct place.

Signed-off-by: Ralf Roesch <ralf.roesch@rw-gmbh.de>
---
 include/linux/sched.h |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
 mode change 100644 => 100755 include/linux/sched.h

diff --git a/include/linux/sched.h b/include/linux/sched.h
old mode 100644
new mode 100755
index c231a24..b633308
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1036,6 +1036,9 @@ static inline int test_sd_parent(struct 
sched_domain *sd, int flag)
     return 0;
 }
 
+unsigned long default_scale_freq_power(struct sched_domain *sd, int cpu);
+unsigned long default_scale_smt_power(struct sched_domain *sd, int cpu);
+
 #else /* CONFIG_SMP */
 
 struct sched_domain_attr;
@@ -1047,10 +1050,6 @@ partition_sched_domains(int ndoms_new, struct 
cpumask *doms_new,
 }
 #endif    /* !CONFIG_SMP */
 
-
-unsigned long default_scale_freq_power(struct sched_domain *sd, int cpu);
-unsigned long default_scale_smt_power(struct sched_domain *sd, int cpu);
-
 struct io_context;            /* See blkdev.h */
 
 
-- 
1.6.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86: sched: fix for non SMP systems in sched.h
  2009-10-30 14:34 [PATCH] x86: sched: fix for non SMP systems in sched.h Ralf Rösch
@ 2009-11-08 11:52 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2009-11-08 11:52 UTC (permalink / raw)
  To: Ralf R??sch; +Cc: a.p.zijlstra, linux-kernel, hpa, mingo, Thomas Gleixner


* Ralf R??sch <ralf.roesch@rw-gmbh.de> wrote:

> commit d65d153bc23b84e4709a49137a9a03ae139d51a0 introduced
> two new prototypes: default_scale_freq_power and default_scale_smt_power.
> Both of them use struct sched_domain which is not defined on non SMP
> systems.
> Just moved the prototypes to the correct place.
> 
> Signed-off-by: Ralf Roesch <ralf.roesch@rw-gmbh.de>
> ---
> include/linux/sched.h |    7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
> mode change 100644 => 100755 include/linux/sched.h
> 
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> old mode 100644
> new mode 100755
> index c231a24..b633308
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -1036,6 +1036,9 @@ static inline int test_sd_parent(struct
> sched_domain *sd, int flag)
>     return 0;
> }
> 
> +unsigned long default_scale_freq_power(struct sched_domain *sd, int cpu);
> +unsigned long default_scale_smt_power(struct sched_domain *sd, int cpu);
> +
> #else /* CONFIG_SMP */
> 
> struct sched_domain_attr;
> @@ -1047,10 +1050,6 @@ partition_sched_domains(int ndoms_new, struct
> cpumask *doms_new,
> }
> #endif    /* !CONFIG_SMP */
> 
> -
> -unsigned long default_scale_freq_power(struct sched_domain *sd, int cpu);
> -unsigned long default_scale_smt_power(struct sched_domain *sd, int cpu);
> -
> struct io_context;            /* See blkdev.h */

FYI, your patch has tabs converted to spaces (and line-wrap problems), 
so it wont apply cleanly.

See Documentation/email-clients.txt about how to send patches without
such problems.

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-11-08 11:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-30 14:34 [PATCH] x86: sched: fix for non SMP systems in sched.h Ralf Rösch
2009-11-08 11:52 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox