From: Nigel Cunningham <ncunningham@crca.org.au>
To: "André Goddard Rosa" <andre.goddard@gmail.com>
Cc: trivial@kernel.org, linux list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/16] trivial: fix assorted "through" typos
Date: Sat, 31 Oct 2009 21:17:34 +1100 [thread overview]
Message-ID: <4AEC0EBE.2040308@crca.org.au> (raw)
In-Reply-To: <b8bf37780910310240u4aecdf89hb938df7952b572e@mail.gmail.com>
I've only looked at this one, but something caught my eye...
André Goddard Rosa wrote:
> diff --git a/arch/blackfin/kernel/cplb-mpu/cplbinit.c
> b/arch/blackfin/kernel/cplb-mpu/cplbinit.c
> index f7b9cdc..b52c1f8 100644
> --- a/arch/blackfin/kernel/cplb-mpu/cplbinit.c
> +++ b/arch/blackfin/kernel/cplb-mpu/cplbinit.c
> @@ -38,7 +38,7 @@ void __init generate_cplb_tables_cpu(unsigned int cpu)
>
> #ifdef CONFIG_BFIN_EXTMEM_DCACHEABLE
> d_cache = CPLB_L1_CHBL;
> -#ifdef CONFIG_BFIN_EXTMEM_WRITETROUGH
> +#ifdef CONFIG_BFIN_EXTMEM_WRITETHROUGH
> d_cache |= CPLB_L1_AOW | CPLB_WT;
> #endif
> #endif
"Surely that can't be the only time?", I thought. But it is - all of the
other #ifdefs are spelled correctly, so you're probably fixing a
hard-to-find bug here! Good catch!
Makes me wonder if anyone's written a tool to find things like this -
#ifdefs that will never be defined...
Regards,
Nigel
next prev parent reply other threads:[~2009-10-31 10:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 9:40 [PATCH 03/16] trivial: fix assorted "through" typos André Goddard Rosa
2009-10-31 10:17 ` Nigel Cunningham [this message]
2009-10-31 10:22 ` André Goddard Rosa
2009-10-31 12:11 ` Tilman Schmidt
2009-11-01 17:52 ` Randy Dunlap
2009-11-01 21:13 ` Thiago Farina
2009-11-02 10:40 ` ARRAY_SIZE (was: [PATCH 03/16] trivial: fix assorted "through" typos) Tilman Schmidt
2009-11-02 10:09 ` Kernel cleanup Wiki " Tilman Schmidt
2009-11-02 9:18 ` [PATCH 03/16] trivial: fix assorted "through" typos Ingo Molnar
2009-11-02 16:00 ` Jiri Kosina
2009-11-02 16:16 ` André Goddard Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEC0EBE.2040308@crca.org.au \
--to=ncunningham@crca.org.au \
--cc=andre.goddard@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox