From: Eric Sandeen <sandeen@redhat.com>
To: Julia Lawall <julia@diku.dk>
Cc: cmm@us.ibm.com, "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger@sun.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] fs/ext4: test the i_flags field of the right structure
Date: Mon, 02 Nov 2009 15:22:52 -0600 [thread overview]
Message-ID: <4AEF4DAC.9080905@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0911022158190.4930@ask.diku.dk>
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Elsewhere, EXT4_EXTENTS_FL is combined with EXT4_I(inode)->i_flags, rather
> than inode->i_flags.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>
> ---
> fs/ext4/inode.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 5c5bc5d..c0e34ab 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -2787,7 +2787,7 @@ static int ext4_da_writepages_trans_blocks(struct inode *inode)
> * number of contiguous block. So we will limit
> * number of contiguous block to a sane value
> */
> - if (!(inode->i_flags & EXT4_EXTENTS_FL) &&
> + if (!(EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) &&
> (max_blocks > EXT4_MAX_TRANS_DATA))
> max_blocks = EXT4_MAX_TRANS_DATA;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-11-02 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 20:58 [PATCH] fs/ext4: test the i_flags field of the right structure Julia Lawall
2009-11-02 21:22 ` Eric Sandeen [this message]
2009-11-15 1:53 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEF4DAC.9080905@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger@sun.com \
--cc=cmm@us.ibm.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox