From: Masami Hiramatsu <mhiramat@redhat.com>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 1/1] perf probe: Annotate variable initialization
Date: Tue, 03 Nov 2009 10:46:21 -0500 [thread overview]
Message-ID: <4AF0504D.3020406@redhat.com> (raw)
In-Reply-To: <1257254947-16789-1-git-send-email-acme@infradead.org>
Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo<acme@redhat.com>
>
> cc1: warnings being treated as errors
> builtin-probe.c: In function ‘parse_probe_event’:
> builtin-probe.c:72: warning: ‘nc’ is used uninitialized in this function
>
> Cc: Masami Hiramatsu<mhiramat@redhat.com>
> Signed-off-by: Arnaldo Carvalho de Melo<acme@redhat.com>
Oops, thank you!
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
> ---
> tools/perf/builtin-probe.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
> index a99a366..8124523 100644
> --- a/tools/perf/builtin-probe.c
> +++ b/tools/perf/builtin-probe.c
> @@ -69,7 +69,7 @@ static struct {
> static void parse_probe_point(char *arg, struct probe_point *pp)
> {
> char *ptr, *tmp;
> - char c, nc;
> + char c, nc = 0;
> /*
> *<Syntax>
> * perf probe SRC:LN
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
prev parent reply other threads:[~2009-11-03 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 13:29 [PATCH 1/1] perf probe: Annotate variable initialization Arnaldo Carvalho de Melo
2009-11-03 15:46 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF0504D.3020406@redhat.com \
--to=mhiramat@redhat.com \
--cc=acme@infradead.org \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox