From: Prarit Bhargava <prarit@redhat.com>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, ebiederm@xmission.com,
akpm@linux-foundation.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH]: use spin_lock_irqsave in try_one_irq()
Date: Wed, 04 Nov 2009 08:17:56 -0500 [thread overview]
Message-ID: <4AF17F04.1030709@redhat.com> (raw)
In-Reply-To: <2674af740911040501p4ef8b6c5jcbd11f1a57dbf8b7@mail.gmail.com>
Yong Zhang wrote:
> From 83ee4c7591aae764f1656bd68f6e95ae112e2e7a Mon Sep 17 00:00:00 2001
> From: Yong Zhang <yong.zhang0@gmail.com>
> Date: Wed, 4 Nov 2009 20:52:45 +0800
> Subject: [PATCH] genirq: try_one_irq() should be called with irq disabled
>
> Prarit report this:
>
<snip>
Testing verifies that this patch works.
P.
> Reported-by: Prarit Bhargava <prarit@redhat.com>
> Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
> ---
> kernel/irq/spurious.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
> index 114e704..bd7273e 100644
> --- a/kernel/irq/spurious.c
> +++ b/kernel/irq/spurious.c
> @@ -121,7 +121,9 @@ static void poll_all_shared_irqs(void)
> if (!(status & IRQ_SPURIOUS_DISABLED))
> continue;
>
> + local_irq_disable();
> try_one_irq(i, desc);
> + local_irq_enable();
> }
> }
>
>
next prev parent reply other threads:[~2009-11-04 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 13:45 [PATCH]: use spin_lock_irqsave in try_one_irq() Prarit Bhargava
2009-11-03 14:58 ` Yong Zhang
2009-11-03 15:03 ` Prarit Bhargava
2009-11-04 9:18 ` Thomas Gleixner
2009-11-04 12:49 ` Yong Zhang
2009-11-04 13:01 ` Yong Zhang
2009-11-04 13:17 ` Prarit Bhargava [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-10-26 18:35 Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF17F04.1030709@redhat.com \
--to=prarit@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox