From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
rdh@east.sun.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] pci/pcie: Avoid unnecessary PCIe link retrains
Date: Fri, 06 Nov 2009 11:48:11 +0900 [thread overview]
Message-ID: <4AF38E6B.3000604@jp.fujitsu.com> (raw)
In-Reply-To: <20091105191138.GN10555@parisc-linux.org>
Matthew Wilcox wrote:
> On Thu, Nov 05, 2009 at 12:05:11PM +0900, Kenji Kaneshige wrote:
>> There are a lot of codes that searches PCI express capability offset
>> in the PCI configuration space using pci_find_capability(). Caching it
>> in the struct pci_dev will reduce unncecessary search. This patch adds
>> an additional 'pcie_cap' fields into struct pci_dev, which is
>> initialized at pci device scan time (in set_pcie_port_type()).
>
> I think adding this should imply the removal of ->is_pcie. pcie_cap == 0
> means !is_pcie.
Right.
But, as you know, we need to change users of is_pcie (including some
adapter card drivers) before removing it.
Thanks,
Kenji Kaneshige
next prev parent reply other threads:[~2009-11-06 2:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 21:38 [PATCH] pci/pcie: Avoid unnecessary PCIe link retrains RDH
2009-11-04 19:03 ` Jesse Barnes
2009-11-04 23:28 ` Bjorn Helgaas
2009-11-05 3:05 ` Kenji Kaneshige
2009-11-05 18:59 ` Bjorn Helgaas
2009-11-05 19:07 ` Matthew Wilcox
2009-11-05 20:29 ` Bjorn Helgaas
2009-11-06 1:15 ` Kenji Kaneshige
2009-11-05 19:11 ` Matthew Wilcox
2009-11-06 2:48 ` Kenji Kaneshige [this message]
2009-11-06 22:00 ` Jesse Barnes
2009-11-05 1:38 ` Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF38E6B.3000604@jp.fujitsu.com \
--to=kaneshige.kenji@jp.fujitsu.com \
--cc=bjorn.helgaas@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=rdh@east.sun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox