From: Jiri Slaby <jirislaby@gmail.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mm] char, moxa: Make isabrds variable global.
Date: Mon, 09 Nov 2009 09:20:45 +0100 [thread overview]
Message-ID: <4AF7D0DD.5030604@gmail.com> (raw)
In-Reply-To: <b9df5fa10911081806m7564f778k35e0308fc5ddfba4@mail.gmail.com>
On 11/09/2009 03:06 AM, Rakib Mullick wrote:
> On 11/7/09, Jiri Slaby <jirislaby@gmail.com> wrote:
>>
>> Sorry I had no time to look into the first patch. And it makes no sense.
>> The driver is unusable on !MODULE && !PCI. So better fix is to disallow
>> whole build on such configurations. Care to fix that?
>>
> Hi Jiri, thanks for your care. Would you please checkout the
> patch below? Is it okay?
Actually I'm idiot. I forgot, that today people can just pass "module
parameters" on the kernel cmdline even on !MODULE in the
KBUILD_MODNAME.param manner. So no, a better fix is to remove !MODULE
ifdefs completely.
Sorry for the confusion.
next prev parent reply other threads:[~2009-11-09 8:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 4:29 [PATCH -mm] char, moxa: Make isabrds variable global Rakib Mullick
2009-11-07 5:08 ` Rakib Mullick
2009-11-07 10:27 ` Jiri Slaby
2009-11-09 2:06 ` Rakib Mullick
2009-11-09 8:20 ` Jiri Slaby [this message]
2009-11-10 17:42 ` Rakib Mullick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF7D0DD.5030604@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox