Re: [PATCH RFC] [X86] performance improvement for memcpy_64.S by fast string.

Ingo Molnar
2009-11-08T10:19:07Z

* Andi Kleen <andi@firstfloor.org> wrote:

> ling.ma@intel.com writes:
>
> > Intel Nehalem improves the performance of REP strings significantly
> > over previous microarchitectures in several ways:
>
> The problem is that it's not necessarily a win on older CPUs to do it
> this way.

I'm wondering, why are you writing such obtruse comments to Intel
submitted patches? I know it and you know it too which older CPUs have a
slow string implementation, and you know the rough order of magnitude
and significance as well and you have ideas how to solve it all.

Instead you injected just the minimal amount of information into this
thread to derail this patch you can see a problem with, but you didnt at
all explain your full opinion openly and honestly and you certainly
didnt give enough information to allow Ling Ma to act upon your opinion
with maximum efficiency.

I.e. you are not being helpful at all here and you are obstructing Intel
folks actively, making their workflow and progress as inefficient as you
possibly can. Why are you doing that?

Ingo