Re: [PATCH] ata: Clean up hard coded array size calculation.

Thiago Farina
2009-11-08T19:45:50Z

On Sun, Nov 8, 2009 at 5:30 PM, Thiago Farina <tfransosi@gmail.com> wrote:
> Use ARRAY_SIZE macro of kernel api instead.
>
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
> ---
>  drivers/ata/sata_mv.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index 6f5093b..a8a7be0 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -2217,7 +2217,7 @@ static unsigned int mv_qc_issue_fis(struct ata_queued_cmd *qc)
>        int err = 0;
>
>        ata_tf_to_fis(&qc->tf, link->pmp, 1, (void *)fis);
> -       err = mv_send_fis(ap, fis, sizeof(fis) / sizeof(fis[0]));
> +       err = mv_send_fis(ap, fis, ARRAY_SIZE(fis));
>        if (err)
>                return err;
>
> --
> 1.6.5.2.150.g1b52a
>
>