Re: [PATCH v7 17/17] tracing: make function graph tracer work with -mmcount-ra-address

David Daney
2009-11-09T22:35:24Z

Wu Zhangjin wrote:
[...]
> + cflags-y += $(call cc-option, -mmcount-ra-address)
[...]
> +#if (__GNUC__ <= 4 && __GNUC_MINOR__ < 5)

Sprinkling the code with these #if clauses is ugly and prone to breakage
I think.

The Makefile part is testing for the same feature.

We do a very similar thing with -msym32, and KBUILD_SYM32. Perhaps you
could rework this patch in a similar manner and test for
KBUILD_MCOUNT_RA_ADDRESS instead of the '(__GNUC__ <= 4 &&
__GNUC_MINOR__ < 5)'

David Daney